Bug: SchemaError missing content, reasoning leak, identical edit string #49017

Summary

Three persistent bugs fixed via source-level patches:

1. oldString === newString throws error (FIXED)

File: packages/core/src/tool/edit.ts

The edit tool now treats identical strings as a no-op instead of throwing ToolFailure. When the LLM generates an edit where oldString equals newString (e.g., to verify current state), it returns a successful no-op response with 0 replacements.

Test updated: packages/opencode/test/tool/edit.test.ts — changed from expecting error to expecting no-op success.

2. SchemaError(Missing key at ["content"]) (FIXED)

File: packages/opencode/src/session/message-v2.ts

Added guard in toModelMessagesEffect to skip assistant messages that only contain reasoning parts with no renderable content (text or tool output). This prevents provider schema validation errors when messages have empty/missing content fields.

3. Reasoning display (ALREADY CORRECT)

Analysis: The CLI already gates reasoning display with --thinking flag (default true in interactive mode, false in non-interactive). The web/desktop UI gates it with showReasoningSummaries prop, defaulting to hide via thinking_mode KV storage.

No source changes needed — the behavior is already correct. Users can disable with --no-thinking in CLI or toggle in UI settings.

Files Changed

• packages/core/src/tool/edit.ts — no-op for identical strings
• packages/opencode/src/session/message-v2.ts — skip reasoning-only messages
• packages/opencode/test/tool/edit.test.ts — updated tests

Testing

• Edit tool test updated and passing
• Content validation guard prevents empty-content messages from reaching providers