v2: declining a tool call is recorded as shutdown, so the declined turn resumes after a server restart #54180

Activity

1. github-actions

   assigned

   nexxeln

   on Oct 9, 2026
2. edwluo commented on Oct 9, 2026

   

   edwluo

   on Oct 9, 2026

   Author

   More actions

   Also reproduced on 2.0.26 with a cancelled question tool call (DELETE /api/session/<id>/form/<form>): form.cancelled → session.tool.failed ("The user dismissed this question") → session.step.failed ("Step interrupted") → session.execution.interrupted {"reason":"shutdown"}, and time_suspended stays set.
3. opencode-agent commented on Oct 9, 2026

   

   opencode-agentBot

   on Oct 9, 2026 – with OpenCode Agent

   Contributor

   More actions

   Thanks for the detailed report. I reproduced this on 2.0.26, and it still happens on the latest v2 (229b422).

   Steps (simulated model, database kept across restarts):

   1. Set shell to ask. The model replies with a single shell call.
   2. Reject the permission request. The tool call shows "The user declined this tool call" and the turn shows "interrupted". The model has received 1 request.
   3. Restart the server with the same database.
   4. Within a few seconds the session sends a second model request containing "The server restarted while you were working…", so the declined turn resumes.

   The script below reproduces it, and the recording and screenshot show the reject step in the TUI. I only counted model requests; I didn't check the interrupted event or time_suspended myself. What I saw matches your analysis of the decline path in step.ts and the "shutdown" default in execution.ts.

   Related: #36347 (keeping permission/question waits across restarts) and #35646 (auto-resume after a restart).

   recording.mp4

   

   Reproduction script (restart.ts)

   // Reproduces #54180: rejecting a permission request is recorded as a shutdown,
   // so the declined turn is resumed after the server restarts.
   // Run: OPENCODE_DRIVE_DB=restart.sqlite OPENCODE_DRIVE_MEDIA_DIR=/workspace/media \
   //        opencode-drive start --name repro54180 --script ./restart.ts   [add --dev <checkout> to run from source]
   // Expected: 1 model request in total. Actual: a 2nd request containing "The server restarted while you were working" after restart.
   import { Effect, Stream } from "effect"
   import { defineScript, Llm } from "opencode-drive"
   
   export default defineScript({
     launch: "manual",
     config: { permissions: [{ action: "*", resource: "*", effect: "allow" }, { action: "shell", resource: "*", effect: "ask" }] } as any,
     run: ({ server, tuis, llm }) =>
       Effect.gen(function* () {
         const requests: string[] = []
         yield* llm.serve((request: any, index) => {
           const text = JSON.stringify(request)
           requests.push(text)
           console.log(`[repro] model request #${index + 1}; mentions restart: ${text.includes("server restarted")}`)
           return index === 0
             ? Stream.make(
                 Llm.toolCall({ index: 0, id: "call_shell", name: "shell", input: { command: "echo hi", description: "say hi" } }),
                 Llm.finish("tool-calls"),
               )
             : Stream.make(Llm.text("Continuing the declined work."))
         })
         yield* server.launch()
         const a = yield* tuis.launch("a", { recording: true })
         yield* a.ui.submit("Run echo hi")
         yield* a.ui.waitFor("Reject", { timeout: 20000 } as any)
         yield* a.ui.screenshot("permission")
         // Choose "Reject" in the permission prompt
         const reject = yield* a.ui.getNode({ role: "option", label: "Reject" } as any)
         yield* a.ui.click(reject)
         yield* Effect.sleep(3000)
         yield* a.ui.screenshot("after-reject")
         console.log(`[repro] model requests after reject: ${requests.length}`)
         yield* a.close()
         yield* server.kill()
         yield* server.launch()
         yield* Effect.sleep(5000)
         const b = yield* tuis.launch("b", { recording: true })
         yield* Effect.sleep(3000)
         yield* b.ui.screenshot("after-restart")
         console.log(`[repro] model requests after restart: ${requests.length}; last mentions restart: ${requests.at(-1)?.includes("server restarted")}`)
       }),
   })

   Run it with opencode-drive: opencode-drive run ./restart.ts. It drives opencode from your PATH.
4. opencode-agent

   added

   reproduced

   on Oct 9, 2026
5. argszero commented on Oct 9, 2026

   

   argszero

   on Oct 9, 2026

   Contributor

   More actions

   I'd like to work on this.

   Confirmed on the current v2 (8eff035): the decline path in session/runner/step.ts interrupts the runner fiber without a reason, and session/execution.ts defaults an interrupt that carries no reason to "shutdown" — so a user decline settles exactly like a process exit: the claim is kept, jobs.cancel is skipped, no idle marker is projected, and the declined turn is resumed after a restart.

   I plan to give a declined tool call its own deliberate stop reason so the claim is released and nothing resumes, plus a test that exercises the decline and the terminal settlement together — as you note, the two halves are only tested apart today.
6. argszero commented on Oct 10, 2026

   

   argszero

   on Oct 10, 2026

   Contributor

   More actions

   Implemented in #54344.

   A declined tool call now reports a deliberate stop before it interrupts, so the settle path no longer reads the reason-less interrupt as shutdown: step.ts calls input.reportDeclined() ahead of its Effect.interrupt, and execution.ts wires that to coordinator.stopReason(sessionID, "user"). jobs.cancel then runs and the claim is released, so the declined turn does not resume after a restart.
7. vleonbonnet

   added a commit that references this issue on Oct 21, 2026

   fix(core): settle a declined tool call as the user's stop

   ...

   653d353