Activity

1. opencode-agent commented on Oct 18, 2026

   

   opencode-agentBot

   on Oct 18, 2026 – with OpenCode Agent

   Contributor

   More actions

   Thanks for the detailed report. I can confirm this on the latest dev (60a5a6c), and v2.0.32 has the same code.

   To reproduce it, I created an opencode-next.db with the historical project/session/session_message tables and bootstrapped a fresh target with the current schema only. I then ran V1Migration.status(), run() and status() twice: once with empty legacy V1 tables in the target and once without them.

   • With empty legacy tables: status is required and the source session is imported.
   • Without legacy tables: status and run() both report completed, session_v2 and session_message stay empty, and no migration.v1-v2 row is written to kv.

   The cause looks like the early hasLegacySessions return in both status() and run() in packages/core/src/database/v1-migration.bun.ts. It happens before the previous-V2 import runs. The source database isn't modified. The test script below reproduces it.

   Reproduction script (fresh-target-import.test.ts)

   // Copy to packages/core/test/ in an opencode checkout and run: bun test test/fresh-target-import.test.ts
   import { expect, test } from "bun:test"
   import { SqliteClient } from "@effect/sql-sqlite-bun"
   import { EffectDrizzleSqlite } from "@opencode/core/database/drizzle"
   import { Database } from "@opencode/core/database/database"
   import { DatabaseMigration } from "@opencode/core/database/migration"
   import { V1Migration } from "@opencode/core/database/v1-migration"
   import { Global } from "@opencode/util/global"
   import { Effect } from "effect"
   import { sql } from "drizzle-orm"
   import { Database as Sqlite } from "bun:sqlite"
   import fs from "fs"
   import os from "os"
   import path from "path"
   
   function makeSource() {
     const dir = fs.mkdtempSync(path.join(os.tmpdir(), "oc-next-"))
     const filename = path.join(dir, "opencode-next.db")
     const s = new Sqlite(filename)
     s.run(`
       CREATE TABLE project (id text PRIMARY KEY, worktree text NOT NULL, vcs text, name text, icon_url text,
         icon_url_override text, icon_color text, time_created integer NOT NULL, time_updated integer NOT NULL,
         time_initialized integer, sandboxes text NOT NULL, commands text);
       CREATE TABLE session (id text PRIMARY KEY, project_id text NOT NULL, workspace_id text, parent_id text,
         fork_session_id text, fork_boundary text, slug text NOT NULL, directory text NOT NULL, path text, title text,
         version text NOT NULL, share_url text, summary_additions integer, summary_deletions integer,
         summary_files integer, summary_diffs text, metadata text, cost real DEFAULT 0 NOT NULL,
         tokens_input integer DEFAULT 0 NOT NULL, tokens_output integer DEFAULT 0 NOT NULL,
         tokens_reasoning integer DEFAULT 0 NOT NULL, tokens_cache_read integer DEFAULT 0 NOT NULL,
         tokens_cache_write integer DEFAULT 0 NOT NULL, revert text, permission text, agent text, model text,
         time_created integer NOT NULL, time_updated integer NOT NULL, time_compacting integer,
         time_archived integer, time_suspended integer);
       CREATE TABLE session_message (id text PRIMARY KEY, session_id text NOT NULL, type text NOT NULL,
         seq integer NOT NULL, time_created integer NOT NULL, time_updated integer NOT NULL, data text NOT NULL);
       INSERT INTO project VALUES ('next-project','/tmp/next','git','Source',NULL,NULL,NULL,1,2,NULL,'[]',NULL);
       INSERT INTO session (id, project_id, slug, directory, title, version, time_created, time_updated)
         VALUES ('ses_next','next-project','next','/tmp/next','Imported','2',10,20);
       INSERT INTO session_message VALUES ('msg_next','ses_next','user',0,12,13,'{"text":"hi","time":{"created":12}}');
     `)
     s.close()
     return { dir, filename }
   }
   
   async function scenario(withLegacy: boolean) {
     const src = makeSource()
     return Effect.runPromise(
       Effect.scoped(
         Effect.gen(function* () {
           const db = yield* EffectDrizzleSqlite.makeWithDefaults()
           yield* DatabaseMigration.apply(db) // real current-schema bootstrap: session_v2, no legacy `session`
           if (withLegacy)
             yield* db.run(sql`CREATE TABLE session (id text PRIMARY KEY, project_id text NOT NULL, workspace_id text,
               parent_id text, slug text NOT NULL, directory text NOT NULL, path text, title text NOT NULL,
               version text NOT NULL, share_url text, summary_additions integer, summary_deletions integer,
               summary_files integer, summary_diffs text, metadata text, cost real DEFAULT 0 NOT NULL,
               tokens_input integer DEFAULT 0 NOT NULL, tokens_output integer DEFAULT 0 NOT NULL,
               tokens_reasoning integer DEFAULT 0 NOT NULL, tokens_cache_read integer DEFAULT 0 NOT NULL,
               tokens_cache_write integer DEFAULT 0 NOT NULL, revert text, permission text, agent text, model text,
               time_created integer NOT NULL, time_updated integer NOT NULL, time_compacting integer,
               time_archived integer)`)
           if (withLegacy) {
             yield* db.run(sql`CREATE TABLE message (id text PRIMARY KEY, session_id text NOT NULL, time_created integer NOT NULL, time_updated integer NOT NULL, data text NOT NULL)`)
             yield* db.run(sql`CREATE TABLE part (id text PRIMARY KEY, message_id text NOT NULL, session_id text NOT NULL, time_created integer NOT NULL, time_updated integer NOT NULL, data text NOT NULL)`)
           }
           return yield* Effect.gen(function* () {
             const before = yield* V1Migration.status()
             const result = yield* V1Migration.run({ nextDatabasePath: src.filename })
             const after = yield* V1Migration.status()
             const sessions = yield* db.all(sql`SELECT id FROM session_v2`)
             const messages = yield* db.all(sql`SELECT id FROM session_message`)
             const kv = yield* db.all(sql`SELECT value FROM kv WHERE key = 'migration.v1-v2'`)
             return { before, result, after, sessions, messages, kv }
           }).pipe(Effect.provideService(Database.Service, { db }))
         }).pipe(
           Effect.provideService(Global.Service, Global.make({ data: src.dir })),
           Effect.provide(SqliteClient.layer({ filename: ":memory:", disableWAL: true })),
         ),
       ),
     )
   }
   
   test("control: fresh target WITH empty legacy tables imports previous V2 db", async () => {
     const r = await scenario(true)
     console.log("with legacy:", JSON.stringify(r))
     expect(r.sessions).toEqual([{ id: "ses_next" }])
   })
   
   test("bug: fresh target WITHOUT legacy tables skips previous V2 import", async () => {
     const r = await scenario(false)
     console.log("without legacy:", JSON.stringify(r))
     expect(r.sessions).toEqual([{ id: "ses_next" }])
   })

   Run it: bun fresh-target-import.test.ts
2. opencode-agent

   added

   reproduced

   on Oct 18, 2026