Skip to content

Unrecognized key(s) binds #855

Closed
Closed

Description

@exoder

Error: Config file at /Users/andrii/.config/opencode/config.json is invalid
↳ Unrecognized key(s) in object: 'help', 'history_previous', 'history_next' keybinds

Activity

  1. rekram1-node commented on Dec 28, 2025

    @rekram1-node
    Contributor

    [automated] Closing due to 90+ days of inactivity. Feel free to reopen if you still need this!

  2. added a commit that references this issue on Apr 7, 2026
  3. momenheshamahmed commented on Jul 29, 2026

    @momenheshamahmed

    Repro confirmed — linked-venue CREATE silently drops schedule, gallery, numVisitors, capacity

    Root cause

    server/services/event-detail/event-detail.service.ts:141-163 — the venueCreateData() method force-nulls/drops these fields whenever the venue is "linked" (propertyId or communityId set), even though the client sends them and the UI shows the inputs unconditionally:

    // Known bug (not fixed here): linked-venue create still force-nulls the
    // fields below even though the client shows those inputs unconditionally.
    numVisitors: linked ? null : (input.numVisitors ?? null),
    capacity: linked ? null : (input.capacity ?? null),
    schedule: linked ? undefined : input.schedule === null ? Prisma.JsonNull : input.schedule,
    imageUrls: linked ? [] : (input.imageUrls ?? []),

    The update path (venueUpdateData(), lines 165-182) does NOT have this bug — it respects partial semantics. So editing an existing linked venue and adding schedule/gallery WILL persist. Only CREATE is affected.

    Repro steps

    1. Open an Event → Venues tab
    2. Click "Add Venue"
    3. Select venue type = Property (or Community), pick a linked option
    4. Fill in schedule blocks (Start Date, End Date, description, per-schedule gallery images)
    5. Fill in the Venue Gallery (imageUrls)
    6. Fill in numVisitors and capacity
    7. Save → success toast appears (no error)
    8. Reload the page / re-open the venue → schedule, gallery, numVisitors, and capacity are all empty/null

    Why the client sends the data

    components/ssp/inventory/event-venues-tab.tsx:435-461 — sharedFields (schedule, imageUrls, numVisitors, capacity) is constructed unconditionally and spread into both the create (line 461) and update (line 455) mutation payloads, regardless of isLinkedVenueType. The Venue Gallery (line 892) and Schedule Gallery (line 1018) JSX sections are NOT gated behind isLinkedVenueType — they render for all venue types.

    Surfaces involved

    • Root surface: server/services/event-detail/event-detail.service.ts — venueCreateData() (lines 141-163)
    • Client payload: components/ssp/inventory/event-venues-tab.tsx — saveCustomVenue() (lines 399-463)
    • Zod schema (no validation gap): server/services/event-detail/event-detail.types.ts:85-95 — venueLinkedFields accepts all fields for linked venues; the drop happens in the service mapper, not the schema.

    Fix scope (not yet applied — awaiting confirmation)

    Remove the linked ? ... : ternary for schedule, imageUrls, numVisitors, and capacity in venueCreateData() so linked venues persist these fields on create, matching the update path's behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions