You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
GH-45937: [C++][Parquet] Logical type definition for variant #46104
changed the title [-][C++][Parquet] Logical type definition for variant[/-][+]GH-45937: [C++][Parquet] Logical type definition for variant[/+]on Apr 10, 2025
Hi @wgtmac, I noticed this issue doesn't have a milestone and it should. It looks to me like the merge script was used to do the merge of #45375 but I'm not 100% sure.
Since it looks like this the PR merged after the 20.0.0 maint branch was created, it wasn't included in the 20.0.0 release so it's fine to include in 21.0.0. We can see it's not on maint-20.0.0 below:
❯ git branch --contains 68f1a0f4e0bae3ef436925ecf23b613b6ac9234b
main
maint-21.0.0
Also, #45937 is in the 21.0.0 milestone but it would better if we removed the parent issue from any milestones and put this issue in 21.0.0. Any objections?
Activity
[-][C++][Parquet] Logical type definition for variant[/-][+]GH-45937: [C++][Parquet] Logical type definition for variant[/+]jayceslesar commentedon Jun 10, 2025
This issue can be closed right?
wgtmac commentedon Jun 19, 2025
I think you are right. Let me close it.
amoeba commentedon Jul 7, 2025
Hi @wgtmac, I noticed this issue doesn't have a milestone and it should. It looks to me like the merge script was used to do the merge of #45375 but I'm not 100% sure.
Since it looks like this the PR merged after the 20.0.0 maint branch was created, it wasn't included in the 20.0.0 release so it's fine to include in 21.0.0. We can see it's not on
maint-20.0.0 below:Also, #45937 is in the 21.0.0 milestone but it would better if we removed the parent issue from any milestones and put this issue in 21.0.0. Any objections?
wgtmac commentedon Jul 8, 2025
@amoeba Yes, it is not included in the 20.0.0. I have removed 21.0.0 milestone from the parent issue.
amoeba commentedon Jul 8, 2025
Thanks @wgtmac!