Repository navigation
Stop copying LogicalPlan and Exprs in CommonSubexprEliminate #10211
Description
Is your feature request related to a problem or challenge?
As part of making the planner faster, we are updating the passes to avoid copying LogicalPlan and Expr (see #9637)
Recent profiling (#9637 (comment)) shows that a non trivial amount of plan time happens in CommonSubexprEliminate
Describe the solution you'd like
I would like to reduce the amount of copying in this pass that it no longer appears in profiling traces
Describe alternatives you've considered
No response
Additional context
No response
Activity
[-]`CommonSubexprEliminate`[/-][+]Stop copying LogicalPlan and Exprs in `CommonSubexprEliminate`[/+]alamb commentedon Apr 24, 2024
I believe @peter-toth is working on this one
peter-toth commentedon Apr 24, 2024
I am, but how this issue relates to #9873? Are they duplicates?
alamb commentedon Apr 24, 2024
Good call -- I think they are dupes. Closing this one
peter-toth commentedon May 1, 2024
@alamb, why did you reopen this?
alamb commentedon May 1, 2024
I am not sure. Sorry about that