Skip to content

Stop copying LogicalPlan and Exprs in RewriteDisjunctivePredicate #10213

Closed

Description

@alamb

Is your feature request related to a problem or challenge?

As part of making the planner faster, we are updating the passes to avoid copying LogicalPlan and Expr (see #9637)

Describe the solution you'd like

I would like to reduce the amount of copying in this pass (even though it doesn't appear in current profiling)

Describe alternatives you've considered

Apply the model from @Lordworms in #10166 to RewriteDisjunctivePredicate .

Additional context

I think this will be a pretty simple refactor with a good existing pattern, so mark this as good first issue

Activity

  1. changed the title [-]`RewriteDisjunctivePredicate`[/-] [+]Stop copying LogicalPlan and Exprs in `RewriteDisjunctivePredicate`[/+] on Apr 24, 2024
  2. rohitrastogi commented on Apr 25, 2024

    @rohitrastogi
    Contributor

    I'll take this one.

  3. alamb commented on Apr 25, 2024

    @alamb
    ContributorAuthor

    Thanks @rohitrastogi 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions