Skip to content

Stop copying LogicalPlan and Exprs in EliminateCrossJoin #10287

Closed

Description

@alamb

Is your feature request related to a problem or challenge?

Part of #9637

As part of making the planner faster, we are updating the optimizer passes to avoid copying LogicalPlan and Expr (see #9637)

Describe the solution you'd like

I would like to reduce the amount of copying in this pass (even though it doesn't appear in current profiling)

Describe alternatives you've considered

Apply the model from @Lordworms in #10166 to this pass
2. Update OptimizerRule::supports_rewrite` to return true

  1. Update OptimizerRule to use rewrite
  2. Update the pass itself to not copy the LogicalPlan (ideally using the TreeNode API) - it is implemented for LogicalPlan (API) and Expr (API)

Other examples: #10218

Additional context

Activity

  1. alamb commented on Apr 29, 2024

    @alamb
    ContributorAuthor

    I believe @Lordworms is working on this -- #9637 (comment)

  2. self-assigned this
    on May 8, 2024
  3. alamb commented on May 8, 2024

    @alamb
    ContributorAuthor

    I am going to give this one a try

  4. alamb commented on May 9, 2024

    @alamb
    ContributorAuthor

    It is done over a few PRs but I have this change now working and I think it is looking quite good: #10431

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions