Repository navigation
Stop copying LogicalPlan and Exprs in ScalarSubqueryToJoin #10294
Description
Is your feature request related to a problem or challenge?
Part of #9637
As part of making the planner faster, we are updating the optimizer passes to avoid copying LogicalPlan and Expr (see #9637)
Describe the solution you'd like
I would like to reduce the amount of copying in this pass (even though it doesn't appear in current profiling)
Describe alternatives you've considered
Apply the model from @Lordworms in #10166 to this pass
2. Update OptimizerRule::supports_rewrite` to return true
- Update
OptimizerRuleto userewrite - Update the pass itself to not copy the LogicalPlan (ideally using the
TreeNodeAPI) - it is implemented forLogicalPlan(API) andExpr(API)
Other examples: #10218
Additional context
Metadata
Metadata
Assignees
Labels
No labels
Activity
rtadepalli commentedon May 7, 2024
take
alamb commentedon May 13, 2024
Since this one is a bit tricky and I don't see any draft PRs yet, I am going to take a shot at a PR as well
rtadepalli commentedon May 14, 2024
Well.. I was finishing up going through the Rust book and that took more than expected because other things came up. I'll pick up another ticket, sorry about the delay.
alamb commentedon May 14, 2024
No worries -- I think this is a pretty tough first PR to work on. I made a PR to do it here: #10489