Skip to content

Support join filter in NestedLoopJoin in fizz join test cases #10787

Open

Description

@edmondop

Is your feature request related to a problem or challenge?

#10728 closes the first part of #10659, however combining the on_filter with the provided join_filter produces wrong results,

---- fuzz_cases::join_fuzz::test_inner_join_1k_filtered stdout ----
thread 'fuzz_cases::join_fuzz::test_inner_join_1k_filtered' panicked at datafusion\core\tests\fuzz_cases\join_fuzz.rs:387:17:
assertion `left == right` failed: NestedLoopJoinExec and HashJoinExec produced different results
  left: (3, "| 21 | 21 | 2078626761  | 1773284061  | 21 | 25 | 1533589294  | 685853846   |")
 right: (3, "| 0  | 75 | -1848255860 | 30924674    | 0  | 75 | 1261908710  | 1064557805  |")
stack backtrace:

Describe the solution you'd like

Add the right logic to the nested inner join loop filter

Describe alternatives you've considered

No response

Additional context

No response

Activity

  1. comphead commented on Jun 6, 2024

    @comphead
    Contributor

    Thats interesting, I'll try to add a test case for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions