Repository navigation
Convert ApproxPercentileCont and `ApproxPercentileContWithWeight to UDAF #10870
Description
Is your feature request related to a problem or challenge?
Similar to #10838 and others #8708
However, there're some challenge to convert ApproxPercentileCont.
I discussed with @jayzhan211 in #10838 (comment)
Describe the solution you'd like
No response
Describe alternatives you've considered
No response
Additional context
No response
Activity
goldmedal commentedon Jun 11, 2024
take
goldmedal commentedon Jun 11, 2024
Hi @jayzhan211,
Continuing from our previous discussion in #10838 (comment), I believe there are still some issues.
We create
AccumulatorArgsinhttps://github.com/apache/datafusion/blob/main/datafusion/physical-expr-common/src/aggregate/mod.rs#L287.
However,
AggregateFunctionExpronly takesargsthat arePhysicalExpr. I thinkAccumulatorArgsis a logical plan struct that should be placed indatafusion-expr. It can't accessPhysicalExpr.Curiously, is it possible to convert
PhysicalExprback toExpr?If not, I plan to pass the original
ExprtoAggregateFunctionExpr(just likesort_exprs: Vec<Expr>), then pass it toAccumulatorArgs.Does this make sense? What do you think?
Thanks
jayzhan211 commentedon Jun 12, 2024
I think it is possible, but in this case, we can just pass the
Expr: Vec<Expr>toAggregateFunctionExprlikeSortExpris[-]Convert `ApproxPercentileCont` to UDAF[/-][+]Convert `ApproxPercentileCont` and ``ApproxPercentileContWithWeight` to UDAF[/+]