Skip to content

Support protobuf serialization for ScalarValue::Utf8View and ScalarValue::BinaryView #12117

Closed

Description

@alamb

Is your feature request related to a problem or challenge?

Part of #11752

We are trying to enable DataFusion to use StringViewArray by default. If we do that it means ScalarValue::Utf8View and ScalarValue::BinaryView will be more likely to be used in plans

Describe the solution you'd like

Thus we need to ensure ScalarValue::Utf8View and ScalarValue::BinaryView can be serialized using datafusion-proto

Describe alternatives you've considered

I recommend adding coverage for ScalarValue::Utf8View and `ScalarValue::BinaryView to the tests here

ScalarValue::Utf8(Some(String::from("Test string "))),
ScalarValue::LargeUtf8(Some(String::from("Test Large utf8"))),

And then update the code to get the tests to pass

Additional context

No response

Activity

  1. changed the title [-]Support protobuf serialization for `ScalarValue::Utf8View` and `ScalarValue::BinaryView[/-] [+]Support protobuf serialization for `ScalarValue::Utf8View` and `ScalarValue::BinaryView`[/+] on Aug 22, 2024
  2. Lordworms commented on Aug 25, 2024

    @Lordworms
    Contributor

    take

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions