Skip to content

Implement RightMark join #13138

Closed
Closed

Description

@eejbyfeldt

Is your feature request related to a problem or challenge?

In #13134 we add a LeftMark join. To allow us to swap the side we build the hashtable for in hash joins we should also implement a RightMark join.

Describe the solution you'd like

We support RightMark join in addition to LeftMark.

Describe alternatives you've considered

Just support LeftMark and accept that performance might be suboptimal.

Additional context

No response

Activity

  1. jonathanc-n commented on Oct 28, 2024

    @jonathanc-n
    Contributor

    take

  2. jonathanc-n commented on Oct 28, 2024

    @jonathanc-n
    Contributor

    Probably will start working on this after #13134 gets merged

  3. eejbyfeldt commented on Oct 31, 2024

    @eejbyfeldt
    ContributorAuthor

    @jonathanc-n #13134 was just merge. Looking forward to the Right join PR let me know if you need any input from me.

  4. jonathanc-n commented on Nov 1, 2024

    @jonathanc-n
    Contributor

    @eejbyfeldt I think that the implementation will just be a mirror of your left join

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions