Skip to content

Type coercion for binary operators forces UTF8View to Utf8 #13348

Closed

Description

@Omega359

Describe the bug

This is a cleanup ticket for #12212 which had introduced logic for regexp forcing coercion to Utf8 if any side had utf8View. This looks to have been done before #12180 landed which to my understanding should negate the need for this.

However, I think fixing regexp_match to support utf8View should likely land before the special handling code and tests introduced in #12212 is removed.

To Reproduce

See

Expected behavior

Utf8View is supported and not coerced to Utf8 for all regexp functions including via binary operators.

Additional context

No response

Activity

  1. jayzhan211 commented on Nov 11, 2024

    @jayzhan211
    Contributor

    I think change the signature to TypeSignature::String can solve this issue. See #13301

  2. jayzhan211 commented on Nov 11, 2024

    @jayzhan211
    Contributor

    regex_comparison_string_coercion is the same as string_coercion, can we remove it and use string_coercion instead?

    I saw the comment 👍

  3. alamb commented on Mar 8, 2025

    @alamb
    Contributor

    I think we have completed this issue now -- let's close it (and if it is not closed, perhaps we can file a ticket that explains the end user effect / reproducer so we can get it fixed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions