Skip to content

get_wider_type in binary.rs does not support utf8view #13360

New issue
New issue
Closed
#14378
Closed
get_wider_type in binary.rs does not support utf8view#13360
#14378
Labels
bugSomething isn't working

Description

@Omega359
Omega359
opened on Nov 11, 2024

Describe the bug

get_wider_type has support for (LargeUtf8, Utf8) and (Utf8, LargeUtf8) however it's missing support for (LargeUtf8, Utf8View) and (Utf8View, LargeUtf8)

To Reproduce

No response

Expected behavior

get_wider_type properly handles utf8view

Additional context

No response

Activity

  1. Omega359
    added
    bugSomething isn't working
    on Nov 11, 2024

  2. alamb commented on Jan 30, 2025

    @alamb
    alamb
    on Jan 30, 2025
    Contributor

    It turns out the only user of get_wider_type as noted by @jayzhan211 and @Omega359 in #13370 (comment)
    So this ticket is really "ensure Utf8View works with array_concat

  3. alamb commented on Jan 30, 2025

    @alamb
    alamb
    on Jan 30, 2025
    Contributor

    I tested and array_concat actually already supports Utf8View

    Here is a proposed fix for get_wider_type (that deletes it):

  4. alamb
    closed this as completedin #14378on Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions