Repository navigation
External Error prefix is repeated multiple times #14080
Description
Describe the bug
I'm getting errors in the form of DataFusionError::External(External(External(External(External(External(xyz)))) when throwing them from https://docs.rs/datafusion/latest/datafusion/physical_plan/trait.ExecutionPlan.html#tymethod.execute
To Reproduce
Implement a TableProvider that throws an error and call it
fn execute(
&self,
partition: usize,
_context: Arc<TaskContext>,
) -> datafusion::common::Result<SendableRecordBatchStream> {
return Err(DataFusionError::Execution(
format!("error"),
));
}
Expected behavior
I'd expect the External(External(External(External(External flattened to just one External
Additional context
- This seems to be a regression as it wasn't happening in e.g., v42
- Similar fixes have been done for other parts of the code fix: Avoid re-wrapping planning errors Err(DataFusionError::Plan) for use in plan_datafusion_err #14000
Activity
Fix display of datafusion errors.
Fix display of datafusion errors.
Omega359 commentedon Jan 11, 2025
I was seeing this with the sqlite tests, thx for creating a ticket for it.
alamb commentedon Jan 13, 2025
I agree this would be nice to fix.
We can potentially do the unwrapping in this From impl:
datafusion/datafusion/common/src/error.rs
Lines 282 to 286 in 63b94c8
But not sure if there are other places too
getChan commentedon Jan 29, 2025
Take
Omega359 commentedon Jan 29, 2025
Note that when this is fixed the sqlite test files will need to be regenerated. See #14290 for a PR to do that.
getChan commentedon Jan 31, 2025
@Omega359 @gz
Can you provide me with code that can reproduce a bug? I want to use it for testing.
alamb commentedon Jan 31, 2025
I think the tests @Omega359 is referring to are the ones in
The challenge is updating the expected results
Omega359 commentedon Jan 31, 2025
https://github.com/apache/datafusion-testing/blob/5b424aefd7f6bf198220c37f59d39dbb25b47695/data/sqlite/random/groupby/slt_good_12.slt#L19568 is an example.