Skip to content

Improve performance sort TPCH q3 with Utf8Vew ( Sort-preserving merging on a single Utf8View ) #15403

Closed

Description

@zhuqi-lucas

Is your feature request related to a problem or challenge?

See the comments,

#15348 (comment)

Sort-preserving merging on a single Utf8View column will cause sort_tpch q3 slow, we need to investigate it.

cc @alamb @2010YOUY01

And for the q 11 case it will be 20% faster with shorter string sort.

#15348 (comment)

To reproduce:

cargo run --profile release-nonlto --bin dfbench -- sort-tpch -p /Users/yongting/Code/datafusion/benchmarks/data/tpch_sf10 -q 3

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response

Activity

  1. changed the title [-]Investigate why Sort-preserving merging on a single `Utf8View` column will cause sort_tpch q3 slow[/-] [+]Improve performance TPCG q3 with Utf8Vew ( Sort-preserving merging on a single `Utf8View` )[/+] on Mar 25, 2025
  2. alamb commented on Mar 25, 2025

    @alamb
    Contributor

    Thanks, added to the list on #15096

  3. changed the title [-]Improve performance TPCG q3 with Utf8Vew ( Sort-preserving merging on a single `Utf8View` )[/-] [+]Improve performance TPCH q3 with Utf8Vew ( Sort-preserving merging on a single `Utf8View` )[/+] on Mar 25, 2025
  4. changed the title [-]Improve performance TPCH q3 with Utf8Vew ( Sort-preserving merging on a single `Utf8View` )[/-] [+]Improve performance sort TPCH q3 with Utf8Vew ( Sort-preserving merging on a single `Utf8View` )[/+] on Mar 27, 2025
  5. zhuqi-lucas commented on Mar 27, 2025

    @zhuqi-lucas
    ContributorAuthor

    Submitted a PR for review, the performance has about 40% improvement for sort-tpch q3 with single stringview column.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions