Skip to content

Reduce Field Copy operations before releasing 48.0.0 #16121

Closed

Description

@timsaucer

Reduce the field copy operations in response to this PR comment:

The only thing I am worried about with this change is the number of Fields that are passed around -- each Field contains an owned String so each time we copy a Field it will force a copy of the String and will potentially slow down planning, especially for large and complex queries.

Do you think it is feasible to update the scalar, aggregate, and window function APIs to use FieldRef instead of Field? That way we can avoid most string copies.

Originally posted by @alamb in #15911 (review)

Activity

  1. self-assigned this
    on May 20, 2025
  2. changed the title [-]Reduce Field Copy operations[/-] [+]Reduce Field Copy operations before releasing 48.0.0[/+] on May 21, 2025
  3. alamb commented on May 21, 2025

    @alamb
    Contributor

    Thanks @timsaucer -- I also added this to the wishlist on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions