Move SortExec partition check to constructor #179

Activity

1. alamb

   added

   datafusion

   on Apr 26, 2021
2. alamb commented on Apr 26, 2021

   

   alamb

   on Apr 26, 2021

   ContributorAuthor

   More actions

   Comment from Hendrik Makait(hendrik.makait) @ 2021-02-14T17:46:12.067+0000:

   I'd love to check that out tomorrow.

   Comment from Hendrik Makait(hendrik.makait) @ 2021-02-15T20:05:17.782+0000:

   Moving this check into the constructor leads to failing tests. As far as I can see, this is because the planner does an optimization step that inserts a merge for children that contain multiple partitions.
   {code:java}
   match plan.required_child_distribution() {
       Distribution::UnspecifiedDistribution => plan.with_new_children(children),
       Distribution::SinglePartition => plan.with_new_children(
           children
               .iter()
               .map(|child| {
                   if child.output_partitioning().partition_count() == 1 {
                       child.clone()
                   } else {
                       Arc::new(MergeExec::new(child.clone()))
                   }
               })
               .collect(),
       ),
   }
   {code}
    What's the reason for moving this check into planning time? How should I proceed?

   Comment from Andy Grove(andygrove) @ 2021-02-16T14:44:11.773+0000:

   I see. Ok, maybe we can't do this at planning time then.
3. andygrove

   closed this as completedon Nov 3, 2024
4. unkloud

   added a commit that references this issue on Mar 23, 2025

   feat: Support BloomFilterMightContain expr (apache#179)

   969f683