Skip to content

Default time_zone config to None  #18204

Closed

Description

@alamb

@alamb With this implementation, yes. To me the logical solution is to allow the time_zone config option to be an Option (and default to None) and fix any existing usage to handle that ... or to detect when the time_zone config option is '' and handle that in the same manner ('' -> None tz)

Originally posted by @Omega359 in #18017 (comment)

Activity

  1. Xuanwo commented on Oct 22, 2025

    @Xuanwo
    Member

    Seems to be a good first issue for me, let me take a look on this.

  2. Xuanwo commented on Oct 22, 2025

    @Xuanwo
    Member

    take

  3. Omega359 commented on Oct 22, 2025

    @Omega359
    Contributor

    I happened to work on this and left the default as

    pub time_zone: Option<String>, default = Some("+00:00".into())

    I'm not sure whether the default should be None (slight change in behaviour) or Some("+00:00".into()).

    Leaning towards the former but the doc on that config option points to it being used in extract .. but I think extract sql now is delegated to date_part which couldn't have used the timezone before since until recently it didn't have access to ConfigOptions ... so that is likely something that should be fixed in another PR

  4. Omega359 commented on Oct 22, 2025

    @Omega359
    Contributor

    Filed #18228 for the extract/date_part issue uncovered in the above comment.

  5. added a commit that references this issue on Oct 29, 2025
  6. Omega359 commented on Nov 4, 2025

    @Omega359
    Contributor

    This issue can be closed with #18359 @alamb

  7. alamb commented on Nov 4, 2025

    @alamb
    ContributorAuthor

    Thanks @Omega359

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions