You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@alamb With this implementation, yes. To me the logical solution is to allow the time_zone config option to be an Option (and default to None) and fix any existing usage to handle that ... or to detect when the time_zone config option is '' and handle that in the same manner ('' -> None tz)
I'm not sure whether the default should be None (slight change in behaviour) or Some("+00:00".into()).
Leaning towards the former but the doc on that config option points to it being used in extract .. but I think extract sql now is delegated to date_part which couldn't have used the timezone before since until recently it didn't have access to ConfigOptions ... so that is likely something that should be fixed in another PR
Activity
Xuanwo commentedon Oct 22, 2025
Seems to be a good first issue for me, let me take a look on this.
Xuanwo commentedon Oct 22, 2025
take
Omega359 commentedon Oct 22, 2025
I happened to work on this and left the default as
I'm not sure whether the default should be None (slight change in behaviour) or Some("+00:00".into()).
Leaning towards the former but the doc on that config option points to it being used in extract .. but I think extract sql now is delegated to date_part which couldn't have used the timezone before since until recently it didn't have access to
ConfigOptions... so that is likely something that should be fixed in another PROmega359 commentedon Oct 22, 2025
Filed #18228 for the extract/date_part issue uncovered in the above comment.
Default time_zone config to None (apache#18204), fixes apache#18219 a…
Change default `time_zone` to `None` (was `"+00:00"`) (#18359)
Omega359 commentedon Nov 4, 2025
This issue can be closed with #18359 @alamb
alamb commentedon Nov 4, 2025
Thanks @Omega359
Change default `time_zone` to `None` (was `"+00:00"`) (apache#18359)