You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Merge duplicated wildcard arms in LogicalPlanBuilder project_with_validation #26308
Is your feature request related to a problem or challenge?
In project_with_validation (expr/src/logical_plan/builder.rs#L2087-L2174), the Wildcard arm (about L2100-L2118) and the QualifiedWildcard arm (about L2119-L2139) are near-identical. Both duplicate the REPLACE handling and the validate branch (normalize then columnize, or pass through), and the validate branch is repeated a third time in the Expression arm. The two wildcard arms differ only in how the expanded expressions are produced.
Describe the solution you'd like
Add two small helpers, push_validated(expr, validate) and apply_replace(expanded, replace), so each wildcard arm only computes its expansion and the rest is shared. The existing wildcard and REPLACE tests cover the behaviour.
Describe alternatives you've considered
None.
Additional context
This is small and self-contained, a good first issue. Line references are pinned to commit 0d79252.
Activity
ozenyunus35 commentedon Oct 14, 2026
take
refactor: share the REPLACE and validation steps of the wildcard arms…