Repository navigation
change extract return types to decimal to align with postgres #3996
Description
extract currently returns i32 which might loss some information
❯ select extract(second from timestamp '2000-01-01T00:00:00.1');
+--------------------------------------------------------+
| datepart(Utf8("SECOND"),Utf8("2000-01-01T00:00:00.1")) |
+--------------------------------------------------------+
| 0 |
+--------------------------------------------------------+
1 row in set. Query took 0.000 seconds.while postgresql returns decimal
willy=# select extract(second from timestamp '2000-01-01T00:00:00.1');
extract
----------
0.100000
(1 row)Describe the solution you'd like
A clear and concise description of what you want to happen.
change it to decimal
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Activity
tustvold commentedon Oct 30, 2022
This likely will want to wait until decimal support is more consistent - see #4036
comphead commentedon Dec 6, 2022
@waitingkuo looks like #4385 will address this ticket? Tests return seconds as floats
waitingkuo commentedon Dec 6, 2022
@comphead this is to align with postgresql to output decimal instead of decimal which could prevent something like this
note that this datafusion-cli is from the
date_part_f64branch[-]change `extract` return types to decimal[/-][+]change `extract` return types to decimal to align with postgres[/+]