Skip to content

Document SQL operators (like @> and ~) #7153

New issue
New issue
Closed
#7264
Closed
Document SQL operators (like @> and ~)#7153
#7264
Labels
documentationImprovements or additions to documentationenhancementNew feature or requestgood first issueGood for newcomers

Description

@alamb
alamb
opened on Jul 31, 2023

Is your feature request related to a problem or challenge?

While reviewing #6885 (review) to add support for @> and <@ array containment operators, I found that there is no documentation on the list of supported datafusion operators

Describe the solution you'd like

I would like documentation for the operators listed in https://github.com/apache/arrow-datafusion/blob/e02ed51b880d09f2156bd192d283aef75cab04b7/datafusion/expr/src/operator.rs#L29-L80

In a new page of the datafusion SQL guide https://arrow.apache.org/datafusion/user-guide/sql/index.html

Describe alternatives you've considered

No response

Additional context

This would be a great way to get introduced to datafusion, fire up the CLI to test it out, and help the community so marking it as a good first issue

Activity

  1. alamb
    added
    documentationImprovements or additions to documentation
    enhancementNew feature or request
    good first issueGood for newcomers
    on Jul 31, 2023

  2. palash25 commented on Aug 6, 2023

    @palash25
    palash25
    on Aug 6, 2023
    Contributor

    I will try to submit a PR for this

  3. spaydar commented on Aug 6, 2023

    @spaydar
    spaydar
    on Aug 6, 2023
    Contributor

    Hi @alamb , I'm new to the project and am trying to push a feature branch I've started work on but am getting the following error message:

    $ git push --set-upstream origin 7153                                                                                     
ERROR: Permission to apache/arrow-datafusion.git denied to spaydar.                                                                                                     
fatal: Could not read from remote repository.                                                                                                                           
                                                                                                                                                                         
Please make sure you have the correct access rights                                                                                                                     
and the repository exists.

    I didn't see anything in the Contributor Guide about needing access granted to push feature branches. git pull works fine. Any tips on how to resolve this?

  4. palash25 commented on Aug 7, 2023

    @palash25
    palash25
    on Aug 7, 2023
    Contributor

    @spaydar that is because you are pushing to the origin repo for which you don't have write access. You will need to fork this repo and then set the url of your fork as a remote. Something like this git remote add fork <fork-url>

    Then push to that remote instead. Once you do that you can create a PR. git push fork <branch-name>

    And please always comment on an issue before you start work on it. As you can see I had already commented on this a few hours before your comment and started some work. If I had seen your comment I wouldn't try to claim this. This avoids duplication of work. 😀

    Since you are ready to push your branch I will stop working on this.

  5. spaydar commented on Aug 7, 2023

    @spaydar
    spaydar
    on Aug 7, 2023
    Contributor

    @palash25 Thank you for your explanation of how to fork and push my code. This is my first time contributing to OSS -- do most OSS projects prefer forking the repo over feature branch development within the same repo?

    Sorry for the duplication of work 🙇‍♂️️ I hope I did not waste too much of your time. Next time I'll comment before I start working on an issue.

  6. palash25 commented on Aug 7, 2023

    @palash25
    palash25
    on Aug 7, 2023
    Contributor

    do most OSS projects prefer forking the repo over feature branch development within the same repo?

    yes because OSS projects can get 100s of contributors and it is a low trust environment so they can't give out write access to new people. You only get write access when you become a maintainer. So you should always clone and git pull from the origin repo but always push to your fork

    I hope I did not waste too much of your time.

    don't worry i had just put in 10 mins of work into my branch.

  7. alamb commented on Aug 7, 2023

    @alamb
    alamb
    on Aug 7, 2023
    ContributorAuthor

    Thank you @palash25 and @spaydar -- good learnings all around on this ticket. @palash25's observations and analysis is correct

  8. alamb
    closed this as completedin #7264on Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentationenhancementNew feature or requestgood first issueGood for newcomers

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions