Skip to content

Implement spilling for PartialSortExec #9170

Open
Open
Implement spilling for PartialSortExec#9170
Labels
enhancementNew feature or request

Description

@alamb
alamb
opened on Feb 9, 2024

Is your feature request related to a problem or challenge?

PartialSortExec was added in #7456 / #9125

While one of the major benefits of this operator is to reduce memory required when sorting data (as it can emit early) we should also handle the case when it still can not fit everything in

Describe the solution you'd like

Add spilling support to PartialSortExec so that if it runs out of memory it will spill to disk rather than error

Describe alternatives you've considered

No response

Additional context

#9153 tracks enabling PartialSort for more queries

Activity

  1. alamb
    added
    enhancementNew feature or request
    on Feb 9, 2024

  2. yyy1000 commented on Feb 15, 2024

    @yyy1000
    yyy1000
    on Feb 15, 2024
    Contributor

    I want to help it.
    Though it seems not a small project, I think there's spilling implementation in SortExec and I can learn from that.

  3. alamb commented on Feb 16, 2024

    @alamb
    alamb
    on Feb 16, 2024
    ContributorAuthor

    Thanks @yyy1000 -- I would definitely recommend

    1. Studying the existing implementation in Sort
    2. Creating a test case that shows the sort being invoked (aka set memory manager low and create a partial sort plan)
    3. Try and refactor / adapt the parts used in sort to also be used in partial sort
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions