Skip to content

[EPIC] Support converting Exprs and LogicalPlans --> SQL Strings #9494

Closed

Activity

  1. devinjdangelo commented on Mar 19, 2024

    @devinjdangelo
    Contributor

    I think that we now have a solid enough foundation on these tasks that it would be a good first issue for a new contributor (#9495 especially). An individual or small number of logical Exprs could be handled in a stand alone PR with a test or two. I think this project is a great way to get more familiar with DataFusion's core data structures and optimization algorithms without already having expertise in database internals.

  2. alamb commented on Mar 19, 2024

    @alamb
    ContributorAuthor

    @devinjdangelo do you think we should file explicit follow on tickets, or do you think the existing PRs / documentation is clear enough about the ask (for someone who has no experience with DataFusion)?

    I can file tickets if you prefer

  3. devinjdangelo commented on Mar 19, 2024

    @devinjdangelo
    Contributor

    @alamb I don't think we should file a ticket for every remaining Expr variant, but we could edit the description of #9495 to list the remaining unimplemented variants and make clear that we are looking for help for anyone interested to implement even just 1 at a time in a PR + write a test.

    Here is the remaining list:

    • InList
    • ScalarFunction
    • Between
    • Case
    • WindowFunction
    • Like
    • ScalarVariable
    • SimilarTo
    • Not
    • IsNotNull
    • IsTrue
    • IsFalse
    • IsUnknown
    • IsNotTrue
    • IsNotUnknown
    • Negative
    • GetIndexedField
    • TryCast
    • Sort
    • Exists
    • Wildcard
    • GroupingSet
    • Placeholder
    • OuterReferenceColumn
    • Unnest
  4. alamb commented on Mar 21, 2024

    @alamb
    ContributorAuthor

    @alamb I don't think we should file a ticket for every remaining Expr variant, but we could edit the description of #9495 to list the remaining unimplemented variants and make clear that we are looking for help for anyone interested to implement even just 1 at a time in a PR + write a test.

    Thank yoU @devinjdangelo -- I filed #9726

  5. changed the title [-][EPIC] Collection of SQL to/from LogicalPlan/Expr tickets[/-] [+][EPIC] Support converting Exprs and LogicalPlans --> SQL Strings[/+] on May 15, 2024
  6. alamb commented on Nov 22, 2024

    @alamb
    ContributorAuthor

    Let's claim this is complete 🎉 All the existing subtasks are closed and now we are working on this in our ongoing operations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions