Skip to content

Optimize ScalarValue list variant using Array trait object #996

Closed

Description

@houqp

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

This comes out from the arrow2 PR started by @jorgecarleitao. Here is a discussion on why it would be more efficient to model ScalarValue as dyn Array: #68 (comment)

Describe the solution you'd like

Change ScalarValue's List variant to:

List(Option<Arc<dyn Array>>, DataType),

Describe alternatives you've considered

Current way of warping every list value with a ScalarValue enum has a lot of overhead on read/write.

Additional context

We should probably wait for the arrow2 PR merge before starting to work on this.

#68 (comment) has more discussion on how we can handle this in ballista's protobuf ser/de.

Activity

  1. alamb commented on Aug 21, 2023

    @alamb
    Contributor

    Closing in favor of #7352 whihc offers a more modern proposal for this same idea. Otherwise known as "its happening!"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions