This repository was archived by the owner on Dec 13, 2018. It is now read-only.
Repository navigation
Conversation
Modified in response to this issue : aspnet-contrib/AspNet.Security.OAuth.Providers#126
|
Hi @SH2015, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! TTYL, DNFBOT; |
Member
|
👎 we can come up with better control flow than returning null. |
Contributor
|
The current code provides a more descriptive failure in case of an error, so we would like to keep that behavior. If you see some particular value in propagating the null value, please log an issue so we can discuss the merits of it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified in response to this issue :
aspnet-contrib/AspNet.Security.OAuth.Providers#126