Skip to content
This repository was archived by the owner on Dec 13, 2018. It is now read-only.

Migrate to netcoreapp2.0 - #1202

Merged
pranavkm merged 2 commits into
rel/2.0.0-preview1from
tratcher/core2
May 5, 2017
Merged

pranavkm merged 2 commits into
rel/2.0.0-preview1from
tratcher/core2

Conversation

@Tratcher

@Tratcher Tratcher commented May 4, 2017

Copy link
Copy Markdown
Member

#1201 I had to remove Microsoft.Owin.Security.Interop and tests due to their crossed dependencies between ASP.NET Core and Katana.

@Tratcher Tratcher added this to the 2.0.0-preview1 milestone May 4, 2017
@Tratcher Tratcher self-assigned this May 4, 2017
@dnfclas

dnfclas commented May 4, 2017

Copy link
Copy Markdown

@Tratcher,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

<PropertyGroup>
<Description>ASP.NET Core middleware that enables an application to use cookie based authentication.</Description>
<TargetFramework>netstandard1.3</TargetFramework>
<TargetFramework>netcoreapp2.0</TargetFramework>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum, does that mean that all the ASP.NET Core projects will no longer target .NET Standard? 😮

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously, this also means that we won't be able to use the security packages on .NET Desktop, since it's not cross-compiled for net46 and no longer targets .NET Standard. Meh.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, for ASP.NET Core 2, most of the libraries will target .NET Core 2 in order to use new APIs that are not yet available in a .NET Standard TFM. Code that needs to target multiple platforms, such as Microsoft.Extensions.*, Entity Framework Core, and a few other libraries, will continue to use .NET Standard.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's insane. Not being able to use the ASP.NET Core packages on .NET Desktop will be blocking for many people. Is this change discussed/announced somewhere? Why not cross-compiling the few packages that could take advantage of netcoreapp2.0 instead of retargeting everything?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refer to dotnet/aspnetcore#2022 (comment) for some more details on this.

@pranavkm
pranavkm merged commit d84abf1 into rel/2.0.0-preview1 May 5, 2017
pranavkm added a commit that referenced this pull request May 5, 2017
@pranavkm
pranavkm deleted the tratcher/core2 branch May 5, 2017 02:28
Eilon added a commit to aspnet/Coherence that referenced this pull request May 5, 2017
Eilon added a commit to aspnet/Coherence that referenced this pull request May 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants