This repository was archived by the owner on Dec 13, 2018. It is now read-only.
Repository navigation
Changes for State and test organization - #233
Closed
brentschmaltz wants to merge 1 commit into
Closed
brentschmaltz wants to merge 1 commit into
brentschmaltz wants to merge 1 commit into
Conversation
ghost
added
the 
Member
There was a problem hiding this comment.
Is the public set really necessary on Message/AuthProperties? can these not be private and only settable via the ctor? If the sets are only needed for unit tests, internal setter seems better than than adding null checks.
Contributor
Author
There was a problem hiding this comment.
This allows users to read a message and modify it. If you think about it, this allows some very powerful extensibility.
Contributor
Author
|
@HaoK @Eilon @tushargupta51 What is needed to pull this code? |
Member
Closed
Contributor
Author
|
Reissued as: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated from clean base.