Repository navigation
central issue for "default extensions" #166
Description
This issue encompasses anything that deals with "what the default extensions are/should be".
- opts.extensions should include '.json' #19 points out that
.jsonis not included in the defaults. - resolve does not preserve
require.extensionslist and assumes only ['.js'] #137 points out thatrequire.extensionsis not used as the defaults - Tape does not pass
require.extensionstoresolvetape-testing/tape#395 is related, but can be addressed with changes intape, unrelated to whateverresolvedoes. - (related but addressed: Node's require.resolve options #150, Absolute paths don't take opts.extensions into account #127, cannot resolve paths with extentions .min.js #90, Missing documentation on how the
extensionsoption is used. #134)
There's some PRs out that are hoping to change the defaults:
- Update to use default
require.extensions#138 dynamically readsrequire.extensionson every call - Update default extensions to match node #145 replaces the default of
.jswith a hardcoded list of the defaultrequire.extensionsvalue
I'm opening this so I can close the other issues, and so any further discussion can happen here.
Please try to read all of the previous discussions before commenting.
Activity
snuggs commentedon Jul 11, 2018
@ljharb well done! I'm subscribed and have my eyes peeled. Seems like as I predicted last year there will be more eyeballs looking in the
require.extensionsdirection.This is a great synopsis but even myself remember you had made a couple suggestions. I wonder what they are currently (especially with the new
.mjsextension add we've been working on with IETF. This way I can see where I can help and take some concerns off your plate.Thoughts?
ljharb commentedon Jul 11, 2018
As it relates to
.mjs, resolve will absolutely add it to the default extension list the instant node ships it unflagged - but not before (that will also be when it's present inrequire.extensionsin node).snuggs commentedon Jul 11, 2018
@ljharb sounds like a plan! Any ref we can use to stick in the description / comment to watchdog?
Seems like you know better than me. I've merely been judging off PTSD of the community and in the classrooms. :-|
FWIW I'm totally against
.mjsand believe it creates some unnecessary social fractures within the ecosystem but that's just my opinion not the community at large's.ljharb commentedon Jul 11, 2018
A file extension is strictly necessary, since Module and Script have distinct (and ambiguous) parsing goals, and a file extension is the proper and sole way to disambiguate textual parsing goals - so this result was inevitable once the choice of two parse goals was made in TC39 back in 2013 or so.
snuggs commentedon Jul 11, 2018
ljharb commentedon Jul 12, 2018
snuggs commentedon Jul 12, 2018
ljharb commentedon Jul 12, 2018
snuggs commentedon Jul 12, 2018
ljharb commentedon Jul 12, 2018
snuggs commentedon Jul 12, 2018
ljharb commentedon Jul 12, 2018