You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey @kate-goldenring to make this work, it seems like we'll need some sort of space for at least some code (for the appropriate languages) in the component-docs repo (code that should mimic the end result of a language guide).
What do you think? If we have that code, then we can write the CI to effectively "test" the guides (the caveat being that keeping the guide and the code in sync has to be done manually at least initially).
@vados-cosmonic thats a good point. I am open to implementing the language examples in each language if we have something like this to make it easier to maintain. I could see the action doing the following:
Bump dependencies
Build the component
Try to run it on the example host
Report any errors
The error could be from the host or components -- a maintainer would need to figure this out
Do you see a different flow/scope?
In generally just knowing that the output wasn't an error/was the right output should be enough to get an idea if the code was failing (and after that hopefully someone takes a look!)
Hey @kate-goldenring it looks like maybe this should be rolled into #241 ? It probably makes more sense for these tests to live there rather than in here -- maybe we can close this issue in favor of the other one
Activity
vados-cosmonic commentedon Oct 31, 2024
Hey @kate-goldenring to make this work, it seems like we'll need some sort of space for at least some code (for the appropriate languages) in the
component-docsrepo (code that should mimic the end result of a language guide).What do you think? If we have that code, then we can write the CI to effectively "test" the guides (the caveat being that keeping the guide and the code in sync has to be done manually at least initially).
kate-goldenring commentedon Oct 31, 2024
@vados-cosmonic thats a good point. I am open to implementing the language examples in each language if we have something like this to make it easier to maintain. I could see the action doing the following:
The error could be from the host or components -- a maintainer would need to figure this out
Do you see a different flow/scope?
vados-cosmonic commentedon Oct 31, 2024
Yeah I think that makes sense to me!
In generally just knowing that the output wasn't an error/was the right output should be enough to get an idea if the code was failing (and after that hopefully someone takes a look!)
vados-cosmonic commentedon Apr 14, 2025
Hey @kate-goldenring it looks like maybe this should be rolled into #241 ? It probably makes more sense for these tests to live there rather than in here -- maybe we can close this issue in favor of the other one
vados-cosmonic commentedon May 15, 2025
A bit late but closing since we reached agreement in #50 (comment) !