Skip to content

Paper banner accept node as child not just string #3111

Closed

Description

@cparros

After working with paper for a bit and using the Banner component I believe there are valid use cases for when the banner could could accept more than just a string. for example a node that is a view with title and text components that can be styled for errors or success dropdown banners.

I am using typescript and am able to compile a workaround wrapped in a few views and TS-ignore but I think expanding the accepted children would be great here. Has there been any discussion or work around this?

Activity

  1. github-actions commented on Mar 8, 2022

    @github-actions

    Hey! Thanks for opening the issue. The issue doesn't seem to contain a link to a repro (a snack.expo.dev link or link to a GitHub repo under your username).

    Can you provide a minimal repro which demonstrates the issue? A repro will help us debug the issue faster. Please try to keep the repro as small as possible and make sure that we can run it without additional setup.

  2. github-actions commented on Mar 8, 2022

    @github-actions

    Couldn't find version numbers for the following packages in the issue:

    • react-native
    • react-native-paper
    • react-native-vector-icons

    Can you update the issue to include version numbers for those packages? The version numbers must match the format 1.2.3.

  3. github-actions commented on Apr 8, 2022

    @github-actions

    Hello 👋, this issue has been open for more than a month without a repro or any activity. If the issue is still present in the latest version, please provide a repro or leave a comment within 7 days to keep it open, otherwise it will be closed automatically. If you found a solution or workaround for the issue, please comment here for others to find. If this issue is critical for you, please consider sending a pull request to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions