Skip to content

fix(go.dev): adjust dark/light application selectors - #1035

Merged
uncenter merged 1 commit into
mainfrom
pr-e67dffad
Jul 1, 2024
Merged

fix(go.dev): adjust dark/light application selectors#1035
uncenter merged 1 commit into
mainfrom
pr-e67dffad

Conversation

@uncenter

Copy link
Copy Markdown
Member

馃敡 What does this fix? 馃敡

Sometimes the data-theme attribute doesn't exist, like if it is your first time visiting the website. This adjusts the theme application selectors to use prefers-color-scheme if there is no attribute set, as if data-theme="auto".

馃棐 Checklist 馃棐

  • I have read and followed Catppuccin's contributing guidelines.
  • I have updated the version appropriately in the ==UserStyle== header of the catppuccin.user.css file.

@uncenter
uncenter requested a review from Flapperoo as a code owner June 30, 2024 22:52
@github-actions github-actions Bot added the go.dev go.dev label Jun 30, 2024
@uncenter

uncenter commented Jul 1, 2024

Copy link
Copy Markdown
Member Author

FYI for userstyles you maintain, you have the responsibility of merging PRs once you've approved them (see https://github.com/catppuccin/userstyles/blob/main/docs/CONTRIBUTING.md#pull-request-review-process) :)

@uncenter
uncenter merged commit f397e58 into main Jul 1, 2024
@uncenter
uncenter deleted the pr-e67dffad branch July 1, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go.dev go.dev

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants