Skip to content

fix(youtube): shorts stats values - #1179

Merged
uncenter merged 2 commits into
mainfrom
unknown repository
Aug 9, 2024
Merged

fix(youtube): shorts stats values#1179
uncenter merged 2 commits into
mainfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Aug 9, 2024

Copy link
Copy Markdown

馃敡 What does this fix? 馃敡

as said in the title
image
image

if your wondering where this is, just go to any short's description and you should find this

馃棐 Checklist 馃棐

  • I have read and followed Catppuccin's contributing guidelines.
  • I have updated the version appropriately in the ==UserStyle== header of the catppuccin.user.css file.

@ghost
ghost requested review from isabelroses and uncenter as code owners August 9, 2024 13:16
@github-actions github-actions Bot added the youtube YouTube label Aug 9, 2024
@uncenter uncenter changed the title fix(youtube): unthemed text fix(youtube): shorts stats values Aug 9, 2024
@uncenter
uncenter merged commit 49534ef into catppuccin:main Aug 9, 2024
@uncenter

uncenter commented Aug 9, 2024

Copy link
Copy Markdown
Member

Try to add more detail to the commit/PR names if possible :)

@ghost

ghost commented Aug 9, 2024

Copy link
Copy Markdown
Author

Try to add more detail to the commit/PR names if possible :)

alright :)
i'll try to add more detail next time

@uncenter

uncenter commented Aug 9, 2024

Copy link
Copy Markdown
Member

No worries, I was very puzzled because I remembered "the same" PR from last week with the same title and almost the same classname, with a screenshot of the same UI! Took me a sec to realize the difference lol.

@ghost

ghost commented Aug 10, 2024

Copy link
Copy Markdown
Author

@uncenter btw do you have any other feedback that improves my PRs/commits?
i want to make my PRs pretty stable and easy to review so i dont make things hard and you dont have to mention the same issue 10 times

@uncenter

Copy link
Copy Markdown
Member

@uncenter btw do you have any other feedback that improves my PRs/commits? i want to make my PRs pretty stable and easy to review so i dont make things hard and you dont have to mention the same issue 10 times

It's on you to learn and remember. I've given you tens of comments with feedback and to be honest I'm losing my patience when I keep having to say the same thing - "add a comment", "pick readable classnames", "put it in the right place" - I sincerely wish the best for you but if you want to keep opening PRs you are going to have to work on those things or else we might not accept PRs from you in the future.

@ghost

ghost commented Aug 10, 2024

Copy link
Copy Markdown
Author

@uncenter yeah i think in the near future i'll try the best as i can to bring these feedback into my prs, i'll use better commit messages, more detailed titles, comments, readable classnames, no micro prs, etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

youtube YouTube

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant