Skip to content

feat(searxng): style guide links - #1450

Merged
WalkQuackBack merged 4 commits into
catppuccin:mainfrom
DokterKaj:patch-1
Jul 12, 2026
Merged

feat(searxng): style guide links#1450
WalkQuackBack merged 4 commits into
catppuccin:mainfrom
DokterKaj:patch-1

Conversation

@DokterKaj

@DokterKaj DokterKaj commented Nov 14, 2024

Copy link
Copy Markdown
Contributor

馃敡 What does this fix? 馃敡

As the title says, distinguishes links from visited links by making them blue and mauve respectively instead of all being the accent colour.

馃棐 Checklist 馃棐

  • I have read and followed Catppuccin's contributing guidelines.
  • I have updated the version appropriately in the ==UserStyle== header of the catppuccin.user.css file.

@github-actions github-actions Bot added the searxng SearXNG label Nov 14, 2024
@uncenter

Copy link
Copy Markdown
Member

The default accent is always the same across websites, we don't change it for specific userstyles.

@DokterKaj

Copy link
Copy Markdown
Contributor Author

In that case it's probably best to hard-code links as blue

Should visited links be hard-coded as mauve or be accented?

@DokterKaj
DokterKaj marked this pull request as draft November 14, 2024 16:06
@uncenter

Copy link
Copy Markdown
Member

Well, according to the style guide visited/followed links would be lavender I believe, not mauve. We haven't made a complete decision on accent links vs style guide links yet, it is likely up to the maintainer to decide which they think looks better for a specific userstyle.

@DokterKaj

Copy link
Copy Markdown
Contributor Author

Lavender is not quite distinct enough from blue at a glance, so I think I'll still go with mauve like the Brave and DDG userstyles.

@DokterKaj

Copy link
Copy Markdown
Contributor Author

Not sure where --color-result-detail-link is used but it has "link" in the name so best to make it blue anyway

@DokterKaj DokterKaj changed the title feat(searxng): visited link colour + change default accent to blue feat(searxng): make links blue and visited links mauve Nov 14, 2024
@DokterKaj
DokterKaj marked this pull request as ready for review November 14, 2024 17:15
@sgoudham

sgoudham commented Nov 14, 2024

Copy link
Copy Markdown
Contributor

Just my two cents, I don't think we should accept a contribution that is against the style guide. We're not making a tradeoff to improve some other highlight in this case either.

Also it does make this userstyles inconsistent with the others. As it stands, none of the userstyles support differentiation between links, on hover and visited so we'd probably just have to encourage users to make local changes if they want that at the minute. I stand corrected, apparently we do make some modifications for links on hover.

In the future, we can probably look towards supporting this with official shades? Curious what @isabelroses and @uncenter think.

@DokterKaj

Copy link
Copy Markdown
Contributor Author

Just my two cents, I don't think we should accept a contribution that is against the style guide.

Do the other browser userstyles have to have visited links be changed to lavender then?

We're not making a tradeoff to improve some other highlight in this case either.

Not quite clear on what this means, sorry

@sgoudham

Copy link
Copy Markdown
Contributor

Do the other browser userstyles have to have visited links be changed to lavender then?

I believe the style guide wasn't necessarily followed here since lavender itself is offered as an accent colour. I don't think it's feasible to update all the userstyles to that.

We'll probably have to define official shades of colours as part of the style guide so that userstyles can standardise on the amount to lighten/darken the links for hover/visited.

Not quite clear on what this means, sorry

Sorry ignore me there, what I said wasn't really relevant.

@DokterKaj

Copy link
Copy Markdown
Contributor Author

I believe the style guide wasn't necessarily followed here since lavender itself is offered as an accent colour.

This shouldn't be a problem since this PR would make links no longer accented; they'd just be blue and mauve (or blue and lavender, if we must adhere to the style guide) so there shouldn't be any clashing.

We'll probably have to define official shades of colours as part of the style guide so that userstyles can standardise on the amount to lighten/darken the links for hover/visited.

That would be ideal, but for now this is probably the best way to re-add this functionality of distinguishing visited links.

@uncenter uncenter added the 2.status: pending Pending until internal discussion, planned updates, etc. label Jan 1, 2025
@WalkQuackBack WalkQuackBack added the 2.status: stale Lacking recent activity label Nov 4, 2025
@WalkQuackBack WalkQuackBack added 4.topic: libraries Relating to the standard library and/or library modules 0.kind: enhancement Improves or expands upon current functionality labels Jan 4, 2026

@uncenter uncenter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay on this. Updated with main, and I think we should be using lavender instead of mauve for visited links - this matches the "followed links" of the style guide. I will update this in the Google userstyle as well.

Comment thread styles/searxng/catppuccin.user.less Outdated
Comment thread styles/searxng/catppuccin.user.less Outdated
@uncenter uncenter removed 2.status: pending Pending until internal discussion, planned updates, etc. 4.topic: libraries Relating to the standard library and/or library modules 2.status: stale Lacking recent activity labels Jan 6, 2026
@uncenter uncenter changed the title feat(searxng): make links blue and visited links mauve feat(searxng): style guide links Jan 6, 2026
@uncenter
uncenter requested a review from WalkQuackBack January 6, 2026 17:34

@ryanccn ryanccn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I disagree with the idea of changing links to the standard style guide link color. IMO in the case of search engines links are the primary interactive elements of the user interface and therefore should follow the accent color rather than the usual prose link color. (Otherwise I don't think there would be a whole lot of opportunities to see the configured accent color other than the tab bar.)

@uncenter

uncenter commented Jan 7, 2026

Copy link
Copy Markdown
Member

Personally, I disagree with the idea of changing links to the standard style guide link color. IMO in the case of search engines links are the primary interactive elements of the user interface and therefore should follow the accent color rather than the usual prose link color. (Otherwise I don't think there would be a whole lot of opportunities to see the configured accent color other than the tab bar.)

I can agree but then we'll need to document this - specifically define "the primary interactive elements" of an interface and outline the exception to style guide practices. cc @WalkQuackBack

@uncenter

uncenter commented Jan 7, 2026

Copy link
Copy Markdown
Member

@ryanccn how do you propose we style visited links differently from normal links for a search engine userstyle, assuming the base link is accent? We usually use (recently at least) lighten(@accent, 5%) for links on hover, fwiw.

@uncenter

uncenter commented Jan 7, 2026

Copy link
Copy Markdown
Member

Lavender is not quite distinct enough from blue at a glance, so I think I'll still go with mauve like the Brave and DDG userstyles.

It's also worth noting this complaint. Not sure if @DokterKaj is still active anymore, but if anyone feels the same they should file an issue on catppuccin/catppuccin and get the style guide changed.

@WalkQuackBack

Copy link
Copy Markdown
Member

I'm really sorry for getting to this so late, but I think this is okay to merge for now in parity with the other search engine ports.

@WalkQuackBack
WalkQuackBack merged commit ce38f6c into catppuccin:main Jul 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.kind: enhancement Improves or expands upon current functionality searxng SearXNG

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants