Skip to content

bsky: unthemed colors and some fixes - #1473

Merged
RoootTheFox merged 3 commits into
catppuccin:mainfrom
teidesu:patch-1
Nov 29, 2024
Merged

bsky: unthemed colors and some fixes#1473
RoootTheFox merged 3 commits into
catppuccin:mainfrom
teidesu:patch-1

Conversation

@teidesu

@teidesu teidesu commented Nov 28, 2024

Copy link
Copy Markdown
Contributor

馃敡 What does this fix? 馃敡

  • inappropriate hover in latte
  • invisible text in latte
  • icon contrast fix in mobile layout
  • unthemed skeletons and thread lines

馃棐 Checklist 馃棐

  • I have read and followed Catppuccin's contributing guidelines.
  • I have updated the version appropriately in the ==UserStyle== header of the catppuccin.user.css file.

@teidesu
teidesu requested a review from RoootTheFox as a code owner November 28, 2024 21:52
@github-actions github-actions Bot added the bsky Bluesky Social label Nov 28, 2024

@RoootTheFox RoootTheFox left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, does fix the latte issues
i have some very minor issues with it (such as the version being 0.0.10) but looks good apart from that!

Comment thread styles/bsky/catppuccin.user.css
Comment thread styles/bsky/catppuccin.user.css

@RoootTheFox RoootTheFox left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@sgoudham

Copy link
Copy Markdown
Contributor

Regarding versioning, I remember winston and I actually discussing at the start that semantic versioning doesn't really matter here and we should probably switch to a different versioning system or just always increment patch and leave it at that.

@RoootTheFox
RoootTheFox merged commit ff53d30 into catppuccin:main Nov 29, 2024
@teidesu
teidesu deleted the patch-1 branch November 29, 2024 13:34
@RoootTheFox

Copy link
Copy Markdown
Member

hm, thats fair - i prefer increasing the minor version when patch overflows (9 -> 10)

maybe consistent versioning scheme guidelines for userstyles are a thing worth considering?

@sgoudham

sgoudham commented Nov 29, 2024

Copy link
Copy Markdown
Contributor

I don't use stylus so I don't know if there are any constraints on versioning from that ecosystem but I think it's worth discussing again.

From what I know at the minute, I think datetime versioning makes a lot of sense here (which can also be automatically updated as part of CI)

@uncenter

Copy link
Copy Markdown
Member

hm, thats fair - i prefer increasing the minor version when patch overflows (9 -> 10)

maybe consistent versioning scheme guidelines for userstyles are a thing worth considering?

This isn't how we do it. We follow the regular, traditional guidelines for semantic versioning; fixes are patch bumps, features are minor bumps, breaking changes are major bumps.

@uncenter

Copy link
Copy Markdown
Member

The commit title here is also incorrect - it doesn't have a commit type. bsky: unthemed colors and some fixes needs to be fix(bsky): misc.

@teidesu

teidesu commented Nov 29, 2024

Copy link
Copy Markdown
Contributor Author

sorry >_<

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bsky Bluesky Social

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants