Skip to content

fix(chatgpt): main bg - #1787

Merged
uncenter merged 2 commits into
catppuccin:mainfrom
ashish0kumar:fix/chatgpt/main-bg
Jun 13, 2025
Merged

fix(chatgpt): main bg#1787
uncenter merged 2 commits into
catppuccin:mainfrom
ashish0kumar:fix/chatgpt/main-bg

Conversation

@ashish0kumar

Copy link
Copy Markdown
Member

馃敡 What does this fix? 馃敡

Fixes unthemed main background

Before After
image image

馃棐 Checklist 馃棐

@ashish0kumar
ashish0kumar requested a review from uncenter as a code owner June 12, 2025 13:11
@github-actions github-actions Bot added the chatgpt ChatGPT label Jun 12, 2025

@uncenter uncenter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd appreciate if we could take a more in-depth look at these kinds of fixes. Your solution might work, but it isn't the right way of doing it. If you look closely, it appears that we only need to set the --bg-primary variable to fix the background. (When a userstyle accumulates lots of haphazard fixes like this one, confusion around where to change things and what code is still needed sets in!)

@ashish0kumar

Copy link
Copy Markdown
Member Author

I'd appreciate if we could take a more in-depth look at these kinds of fixes. Your solution might work, but it isn't the right way of doing it. If you look closely, it appears that we only need to set the --bg-primary variable to fix the background. (When a userstyle accumulates lots of haphazard fixes like this one, confusion around where to change things and what code is still needed sets in!)

You're right, apologies! I鈥檒l keep this in mind and make sure to go for more precise fixes moving forward. Thanks for pointing it out!

@ashish0kumar
ashish0kumar requested a review from uncenter June 12, 2025 13:23
@uncenter
uncenter merged commit 38b6389 into catppuccin:main Jun 13, 2025
@ashish0kumar
ashish0kumar deleted the fix/chatgpt/main-bg branch June 14, 2025 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chatgpt ChatGPT

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants