feat(lib/mediawiki): use codex style guide - #1962
Conversation
|
Related to #1866 |
|
Can you explain more about what these changes do or fix? |
Sure! Using the latest version of the library, there's cases where table backgrounds and borders use the same colour which is bad for contrast. In addition, there was a few unthemed variables that are used on other MediaWiki wikis but are part of the Codex style guide spec. This is using feat/mediawiki-lib-integrate modified to point to both versions of the libraries as they are not deployed yet. First example, on Wikipedia - Help:Sortable_tables
_After PR_
Second example, on Wikipedia - Help:Introduction_to_tables_with_Wiki_Markup when signed out.
_After PR_
Third example, in the footer on Wikipedia. Contrast is improved by a lot, closer to matching the style guide contrast recommendations.
_After PR_
Fourth example, buttons now have a colour change when pressed.
_After PR, hover_
_After PR, active_
|
|
@uncenter Is this okay to merge given the approval, or is there any feedback I should act on? |
|
See above comment reply |
|
Made the changes; |
uncenter
left a comment
There was a problem hiding this comment.
A little apprehensive of some of the color mixing because that isn't defined anywhere style guide-wise.
|
For all the set ones, those are set to have higher specificity over the existing theme on the website if they override those variables. |
|
I'm just clarifying that by default, Mediawiki's value for |
I agree, the transparent variables don't need to be set again. Removing them. |
* feat(lib/mediawiki): use codex style guide to base colour choices * chore(lib/mediawiki): comment nits * fix(lib/mediawiki): change button quiet hover colours to fade accent * fix(mediawiki): remove redundant transparent variables * fix(lib/mediawiki): change tab list framed state colours to latte fade --------- Co-authored-by: uncenter <uncenter@uncenter.dev>
* feat(lib): add mediawiki lib module * fix(lib/mediawiki): remove site specific styling * refactor(lib/mediawiki)!: nest utilities under namespace * fix(lib/mediawiki): adjust border colors slightly * fix(lib/mediawiki): adjust borders further * feat(lib/mediawiki): use codex style guide (#1962) * feat(lib/mediawiki): use codex style guide to base colour choices * chore(lib/mediawiki): comment nits * fix(lib/mediawiki): change button quiet hover colours to fade accent * fix(mediawiki): remove redundant transparent variables * fix(lib/mediawiki): change tab list framed state colours to latte fade --------- Co-authored-by: uncenter <uncenter@uncenter.dev> * feat(lib/mediawiki): radio inputs * refactor(lib/mediawiki): move to versioned path --------- Co-authored-by: WalkQuackBack <quacksareback@duck.com>
# This is the 1st commit message: feat(lib): add mediawiki lib module # This is the commit message catppuccin#2: fix(lib/mediawiki): remove site specific styling # This is the commit message catppuccin#3: refactor(lib/mediawiki)!: nest utilities under namespace # This is the commit message catppuccin#4: fix(lib/mediawiki): adjust border colors slightly # This is the commit message catppuccin#5: fix(lib/mediawiki): adjust borders further # This is the commit message catppuccin#6: feat(lib/mediawiki): use codex style guide (catppuccin#1962) * feat(lib/mediawiki): use codex style guide to base colour choices * chore(lib/mediawiki): comment nits * fix(lib/mediawiki): change button quiet hover colours to fade accent * fix(mediawiki): remove redundant transparent variables * fix(lib/mediawiki): change tab list framed state colours to latte fade --------- Co-authored-by: uncenter <uncenter@uncenter.dev>
fix(lib/mediawiki): remove site specific styling refactor(lib/mediawiki)!: nest utilities under namespace fix(lib/mediawiki): adjust border colors slightly fix(lib/mediawiki): adjust borders further feat(lib/mediawiki): use codex style guide (catppuccin#1962) * feat(lib/mediawiki): use codex style guide to base colour choices * chore(lib/mediawiki): comment nits * fix(lib/mediawiki): change button quiet hover colours to fade accent * fix(mediawiki): remove redundant transparent variables * fix(lib/mediawiki): change tab list framed state colours to latte fade --------- Co-authored-by: uncenter <uncenter@uncenter.dev> Initial commit for manpages. Also fix up arch wiki guidance. Signed-off-by: Toria <ninetailedtori@uwu.gal> Fix issues. Now I just need to sort out the fmt issues. We can't split regexp onto multiple lines or it breaks the usercss in stylus, which is unfortunate. Signed-off-by: Toria <ninetailedtori@uwu.gal> This fixes a few things - firstly, this style only works on Arch's manpage. Perhaps it's worth generating its own category, and including ALL manpage supports, but we could actually do it all under one thing. Signed-off-by: Toria <ninetailedtori@uwu.gal> Let's do this with a major rework. Let's add support to all manpages to this one file, to keep it neat and organised. Signed-off-by: Toria <ninetailedtori@uwu.gal> Rework - let's do a rework to include it all under an archlinux category! Signed-off-by: Toria <ninetailedtori@uwu.gal> Rework wiki theme to fit mediawiki. This requires: catppuccin#1866. manpage for arch has been finalized and perfected. Signed-off-by: Toria <ninetailedtori@uwu.gal> Remove README (this is autogenerated, no need to move.) Signed-off-by: Toria <ninetailedtori@uwu.gal> Initial merge of PR catppuccin#1870. Being edited by me, don't mind the state of it rn, feel free to report bugs to me! Signed-off-by: Toria <ninetailedtori@uwu.gal> Cleanup! Simplify some of the css, reformat. Signed-off-by: Toria <ninetailedtori@uwu.gal> Whoops, typo! Signed-off-by: Toria <ninetailedtori@uwu.gal> Move generics into global domain changes. Fix unnecessary redefinitions. Signed-off-by: Toria <ninetailedtori@uwu.gal> Push a few changes to table colouring. Accidentally typo'd a change. Signed-off-by: Toria <ninetailedtori@uwu.gal> Big rework electric booga2 Move label, fix some bugs of overwriting, still needs some table and heading definitions to move as well. I *should've* fixed most things, but oh well. Also, border-color: surface0 -> surface2 now! Signed-off-by: Toria <ninetailedtori@uwu.gal> Veeeeeeery big update, working on EVERYTHING!!! Signed-off-by: Toria <ninetailedtori@uwu.gal> S...spaces? spaces??? Signed-off-by: Toria <ninetailedtori@uwu.gal> deno fmt Signed-off-by: Toria <ninetailedtori@uwu.gal> Fix a few things: timestamp, rss-icon, colors of h3. Need to still do selective rss-icon colours. Signed-off-by: Toria <ninetailedtori@uwu.gal> Fix rss-icon theming. Signed-off-by: Toria <ninetailedtori@uwu.gal> Rework of some of the colours Especially links css structure. Still tryna work out some bugs, oddly enough bbs overwrites a ton. Signed-off-by: Toria <ninetailedtori@uwu.gal> Add usercontent. Final commit for tonight! Signed-off-by: Toria <ninetailedtori@uwu.gal> Checklist and rbox support. I know, should be in bed rn qwq Signed-off-by: Toria <ninetailedtori@uwu.gal> Quick fix to links, quick change to li a for bbs. Add colours to sticky and closed labels as well. Signed-off-by: Toria <ninetailedtori@uwu.gal> Fix link backgrounds borking on bbs. Signed-off-by: Toria <ninetailedtori@uwu.gal> Add support for downloads.archlinux. Just needed h5! Signed-off-by: Toria <ninetailedtori@uwu.gal> Add errorlist for search errors. Fix selections. Can't seem to fix cursor-based focus selections though. Needs debugging. Signed-off-by: Toria <ninetailedtori@uwu.gal> Remove cursor setting - we shouldn't touch it in our userstyles. Signed-off-by: Toria <ninetailedtori@uwu.gal> Remove padding from button. Aesthetic choice, should push these upstream. Signed-off-by: Toria <ninetailedtori@uwu.gal> Exclude gitlab.archlinux.org in global Issue was domain(archlinux.org) scope, now uses negative lookahead regex to solve issues. Signed-off-by: Toria <ninetailedtori@uwu.gal> Whoops, missed the commit. Signed-off-by: Toria <ninetailedtori@uwu.gal> Fixing a dicy issue with regex, everything works now! Signed-off-by: Toria <ninetailedtori@uwu.gal> Fix regex to ACTUALLY work! Apparently you can't numeric modifier before lookaheads and behinds because of various logic reasons...wish you could skip when doing lookaheads, like look 2 ahead/behind etc... Signed-off-by: Toria <ninetailedtori@uwu.gal> Comment changes, form input spec. comment: // -> /**/ form input: button text color -> link color (form inputs follow link button style.) Signed-off-by: Toria <ninetailedtori@uwu.gal> Working on an initial change. This won't make sense just yet. Signed-off-by: Toria <ninetailedtori@uwu.gal> Fix mediawiki + remove redundants. remove container from mw for now, add vector-pinned-container settings to inherit directly on the page (flows a lot better, fitting in line with our mw style.) Signed-off-by: Toria <ninetailedtori@uwu.gal> Do NOT break this again. Moving stuff to lib/mediawiki to better organise miniserve in the meantime. Remove unnecessary note now that issue has been patched. Signed-off-by: Toria <ninetailedtori@uwu.gal> Change inline code bg to surface0. Add in unimplemented values. Comment EVERYTHING in wiki section. Refactor archlinux -> arch-linux. Signed-off-by: Toria <ninetailedtori@uwu.gal> Remove manual setting of vector-pinned-container. The issue is both archwiki-toc-* variables should be respected upstream, but also that vector-pinned-containers should be set in mediawiki as well if possible. Signed-off-by: Toria <ninetailedtori@uwu.gal> Err, add theming for git diff table. Signed-off-by: Toria <ninetailedtori@uwu.gal> Reformat! Signed-off-by: Toria <ninetailedtori@uwu.gal> Simplify regex. Signed-off-by: Toria <ninetailedtori@uwu.gal> swap to url-prefix part 1 Co-authored-by: uncenter <uncenter@uncenter.dev> part 2 catppuccin.user.less Co-authored-by: uncenter <uncenter@uncenter.dev> swap to background-image. catppuccin.user.less Co-authored-by: uncenter <uncenter@uncenter.dev> Typo fixes on the latest regex issue. Signed-off-by: Toria <ninetailedtori@uwu.gal> svg changes. restructuring into mixins will be next. note: security.archlinux.org or aur.archlinux.org icons might not work if content-security-policy blocks it. Signed-off-by: Toria <ninetailedtori@uwu.gal> Revert to a crazy fix attempt, remove dupe, use background-image solution. Signed-off-by: Toria <ninetailedtori@uwu.gal> Quickly move around some stuff in brdmenu. Fix up stats. Gotta go fast! Gotta do mixins next. Signed-off-by: Toria <ninetailedtori@uwu.gal> Big batch of mixins and mayhem! TOC variables should NOT be used, and possibly the other archwiki variables in the wiki, but am awaiting response on whether this will change: https://gitlab.archlinux.org/archlinux/archwiki/-/issues/91#note_387552 Signed-off-by: Toria <ninetailedtori@uwu.gal> Perfect the quotebox highlighting on hover! I might be actually godly at this now...knock on wood... Signed-off-by: Toria <ninetailedtori@uwu.gal> Quick url patch, accidentally auto-formatted an error! Signed-off-by: Toria <ninetailedtori@uwu.gal> Add FIXME comment, gotta work on this next. Signed-off-by: Toria <ninetailedtori@uwu.gal> Add dl, dt, dd. This covers newslist on main menu. Welcoming testing/fixing on this, hover box AND alternating colours don't seem to match up with this yet unfortunately. Signed-off-by: Toria <ninetailedtori@uwu.gal> Add footer, add ssdiff, add clarity fixes to colours on diff viewing on package sites. Need a second opinion on the background highlighting, might need to make it even more transparent? Signed-off-by: Toria <ninetailedtori@uwu.gal> Fix some inputs 1. add mw-ui-icon-wiki-expand definition to remove our colours. 2. move borders to accent 3. add focus-within tags to all inputs, to theme accurately. 4. move enabled, that shouldn't even be there, should be with &:enabled! - I need to still do disabled for all inputs though. 5. Add input[type="submit"], which is useful for some pages, e.g. - https://wiki.archlinux.org/index.php?title=Special:Search&profile=images&search=&fulltext=1 Signed-off-by: Toria <ninetailedtori@uwu.gal> Fix a few styling consistency things with deno task lint. Signed-off-by: Toria <ninetailedtori@uwu.gal> Working on radio and checkbox. Still need to add disabled. Signed-off-by: Toria <ninetailedtori@uwu.gal> Fix the search, but it's still broken. Test disabled entry? Uncertain if it works yet. Signed-off-by: Toria <ninetailedtori@uwu.gal> Push radio widget theming upstream. Signed-off-by: Toria <ninetailedtori@uwu.gal> feat(lib/mediawiki): radio inputs Commit radio input changes! Signed-off-by: Toria <ninetailedtori@uwu.gal> Big batch of "match the og style" :] not finished yet, given I deleted a lot of my og style, and need to work it back. Generalise the inputs, to attack email correctly (can't be set selectively or we get CSP banned.) Signed-off-by: Toria <ninetailedtori@uwu.gal> Push big change to some other stuff again, cleaning up. Signed-off-by: Toria <ninetailedtori@uwu.gal> Trying to fix bbs now. Signed-off-by: Toria <ninetailedtori@uwu.gal> Big rework on bbs. fixing EVERYTHING again! Signed-off-by: Toria <ninetailedtori@uwu.gal> Fix quick bug with blockquotes. Signed-off-by: Toria <ninetailedtori@uwu.gal> Adding some final fixes for bbs. Still working on stuff, mostly wiki fix. One more syntax error left? Signed-off-by: Toria <ninetailedtori@uwu.gal> Tidy up archnavbarlist. Move colour to text by default. Amend formatting, formatter seems broken. Signed-off-by: Toria <ninetailedtori@uwu.gal> Fix the background-image changes. Signed-off-by: Toria <ninetailedtori@uwu.gal> Fix specificity of navbarlist. Signed-off-by: Toria <ninetailedtori@uwu.gal> Add theming per subpage on aur. Signed-off-by: Toria <ninetailedtori@uwu.gal> MORE PATCHING!!! Signed-off-by: Toria <ninetailedtori@uwu.gal> Comment the aur subpage units! Signed-off-by: Toria <ninetailedtori@uwu.gal> Fix checklists, fix some headers. Signed-off-by: Toria <ninetailedtori@uwu.gal> Add radio inputs pr, add fix for links. Needs to add upstream too, ignore for now. Signed-off-by: Toria <ninetailedtori@uwu.gal> Update mediawiki url to upstream. Signed-off-by: Toria <ninetailedtori@uwu.gal> Fix a weird mw issue. Will push upstream. Signed-off-by: Toria <ninetailedtori@uwu.gal> Remove important. Seems to work fine now. Signed-off-by: Toria <ninetailedtori@uwu.gal> fix(arch-linux): apply mediawiki lib module correctly Remove fix from mw. Signed-off-by: Toria <ninetailedtori@uwu.gal> Add comments header formatting, and some metadata settings. Also, nest metadata under pkgdetails for neatness. Signed-off-by: Toria <ninetailedtori@uwu.gal> Add border change to headers. Useful in way too many places, not neatly overwritten otherwise. Signed-off-by: Toria <ninetailedtori@uwu.gal> Add pin-comment, remove dupe. Signed-off-by: Toria <ninetailedtori@uwu.gal> Little too specific on the css. Mimic upstream aurweb.css, root .*-comment classes. Signed-off-by: Toria <ninetailedtori@uwu.gal> Fix mw thing Signed-off-by: Toria <ninetailedtori@uwu.gal> remove importance from radio inputs, add oo-ui-input and button. Signed-off-by: Toria <ninetailedtori@uwu.gal> Fix diffs for wiki. Signed-off-by: Toria <ninetailedtori@uwu.gal> Move icon inversion to mw lib. Signed-off-by: Toria <ninetailedtori@uwu.gal> Move .mw-protection-indicator-icon--lock to global, unneeded by bbs afaik. Add fallback for browsers that don't support mask-image protocols. Signed-off-by: Toria <ninetailedtori@uwu.gal> Add extiw to the link icons. Signed-off-by: Toria <ninetailedtori@uwu.gal> Add error, move to minify slightly. Signed-off-by: Toria <ninetailedtori@uwu.gal> Add background-color inherit to fix delete-comment bug. Signed-off-by: Toria <ninetailedtori@uwu.gal> Add override for manpages. Signed-off-by: Toria <ninetailedtori@uwu.gal> Comment spree, fix AUR register subdupe, write login as separate. Signed-off-by: Toria <ninetailedtori@uwu.gal> Make comment-header apply to base as well, required for some other comment-headers. Signed-off-by: Toria <ninetailedtori@uwu.gal> Add some old bug page theming. Signed-off-by: Toria <ninetailedtori@uwu.gal> Add mw-file-element. Remove importance from filters, breaks icons. Add intl support! Signed-off-by: Toria <ninetailedtori@uwu.gal> Move icon theming to base. Add check for svg. Arch only uses simple icons. Signed-off-by: Toria <ninetailedtori@uwu.gal> Push change, add specificity, add icon. Signed-off-by: Toria <ninetailedtori@uwu.gal> Formatting manually. Linter broken. Signed-off-by: Toria <ninetailedtori@uwu.gal> Add merge-2 icon. Signed-off-by: Toria <ninetailedtori@uwu.gal> Move mediawiki to eventual upstream. Optimise svg. Signed-off-by: Toria <ninetailedtori@uwu.gal> Remove silly things, add next and prev. Add refresh red arrows. Signed-off-by: Toria <ninetailedtori@uwu.gal> optimise svg again. Signed-off-by: Toria <ninetailedtori@uwu.gal> Codebox fixes. Signed-off-by: Toria <ninetailedtori@uwu.gal> Fix links for visited etc. Signed-off-by: Toria <ninetailedtori@uwu.gal> set default postsig colour. Signed-off-by: Toria <ninetailedtori@uwu.gal> Push some specificity about the tables. Add arch-bio-entry formatting. Signed-off-by: Toria <ninetailedtori@uwu.gal> Whoops, wack a reset on that header include again. Signed-off-by: Toria <ninetailedtori@uwu.gal> Add mailing list support, add manpages correction, add fix for brdmenu isactive tab. Signed-off-by: Toria <ninetailedtori@uwu.gal> add a deno fmt. task lint throwing a fit where it shouldn't, ignore. Signed-off-by: Toria <ninetailedtori@uwu.gal> Further support for mailing lists site. Signed-off-by: Toria <ninetailedtori@uwu.gal> Work to add manpages mdoc macro definitions. Consider moving to lib if popular enough, like most manpage sites use it. Signed-off-by: Toria <ninetailedtori@uwu.gal> Push some changes for the blob table, nest nest nest!!! Signed-off-by: Toria <ninetailedtori@uwu.gal> Push some deno fixes to fix the linting throws. Signed-off-by: Toria <ninetailedtori@uwu.gal> Push some more blocking. Signed-off-by: Toria <ninetailedtori@uwu.gal> Push fix for thead and th. Signed-off-by: Toria <ninetailedtori@uwu.gal> Push bootstrap import, needs changing when bs lib gets made. Need to make a pf lib too. Signed-off-by: Toria <ninetailedtori@uwu.gal> Add some work for accounts.archlinux.org. Signed-off-by: Toria <ninetailedtori@uwu.gal> Add avatar icon too. Signed-off-by: Toria <ninetailedtori@uwu.gal> Add loading container Signed-off-by: Toria <ninetailedtori@uwu.gal> Revert "Merge remote-tracking branch 'upstream/main' into manpages" This reverts commit 9a46870, reversing changes made to 94ca77e. Add important as red. Signed-off-by: Toria <ninetailedtori@uwu.gal> docs(lib/mediawiki): initial documentation writeup (catppuccin#2089)
* feat(lib/mediawiki): use codex style guide to base colour choices * chore(lib/mediawiki): comment nits * fix(lib/mediawiki): change button quiet hover colours to fade accent * fix(mediawiki): remove redundant transparent variables * fix(lib/mediawiki): change tab list framed state colours to latte fade --------- Co-authored-by: uncenter <uncenter@uncenter.dev>










Use the Wikimedia Codex color design tokens to base the colour bindings.
This makes the appearance of the style more consistent with base Wikipedia.