Skip to content

feat: add devcontainer config - #2294

Open
WalkQuackBack wants to merge 1 commit into
mainfrom
feat/add-devcontainer-config
Open

feat: add devcontainer config#2294
WalkQuackBack wants to merge 1 commit into
mainfrom
feat/add-devcontainer-config

Conversation

@WalkQuackBack

Copy link
Copy Markdown
Member

Adds a .devcontainer configuration to be used in GitHub Codespaces and VSCode containers.

References:

Adds a .devcontainer configuration to be used in GitHub Codespaces containers.

// Use 'postCreateCommand' to run commands after the container is created.
// Install git-lfs as it is required to push to the repo
"postCreateCommand": "sudo apt update && sudo apt install -y git-lfs && git lfs install",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this specific to our setup? I would think we can avoid this now - we should have removed all the git lfs assets already, maybe we forgot to remove the plumbing?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still enabled for the GitHub repository, so any attempts to push changes will error out as it's not installed.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shoot. Let me open a tracking issue.

Comment on lines +19 to +23
"vscode": {
"extensions": [
"justjavac.vscode-deno-extensionpack"
]
}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, it's just what the generator put there when setting up Deno.

Comment thread .devcontainer/Dockerfile
@@ -0,0 +1,3 @@
FROM denoland/deno:bin-2.9.3 AS deno

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love to avoid having to pin another version of Deno here hmmm.

@uncenter uncenter mentioned this pull request Jul 24, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants