chore: add pull request template picker and userstyle update template - #308
Merged
Conversation
Member
|
I like this PR and I have no reasons to reject it. |
Member
Author
|
Totally. I realize this is a different kind of change so I'll let you guys (maintainers) figure out if this is a good thing to implement going forward. |
Member
Author
|
Here's a demonstration of it in action: Screenshot.2023-11-14.at.11.32.10.Arc.-converted.mp4It works by appending a query string linking to a template, see https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/using-query-parameters-to-create-a-pull-request. You can fork my test repo, make a change, and try it out yourself: https://github.com/uncenter/pull-request-template-test. |
sgoudham
approved these changes
Nov 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've seen @isabelroses comment about updating the version when someone fixes a userstyle a million times and I think it might help if we have a PR template checklist for that. Turns out GitHub doesn't have a pull request template picker (like the issue template picker) so you have to do this little workaround with query strings.