feat(import-styles): init - #399

Merged

isabelroses merged 33 commits into

mainfrom

Dec 15, 2023

isabelroses commented Dec 13, 2023

Member

Allows for a mass import of userstyles.
We can enforce settings upon users making our lives easier.

isabelroses added 2 commits

December 13, 2023 21:59


          feat(import-styles): init

ceba3d4


          ci(import): rename

babe291

isabelroses requested a review from nekowinston

December 13, 2023 22:09

uncenter reviewed

View reviewed changes

.github/workflows/generate-import.yml Outdated

uncenter reviewed

View reviewed changes

README.md Outdated


          fix: ci paths

5ef4a19

Co-authored-by: uncenter <47499684+uncenter@users.noreply.github.com>

uncenter reviewed

View reviewed changes

deno.json Outdated


          style: trailing new line

6bf2f64

uncenter reviewed

View reviewed changes

scripts/import-styles/main.ts Outdated

isabelroses and others added 2 commits

December 13, 2023 22:22


          docs: improve installation notes

e0126b2

Co-authored-by: uncenter <47499684+uncenter@users.noreply.github.com>


          Merge remote-tracking branch 'refs/remotes/origin/ci/gen-import' into…

4a2d76e

… ci/gen-import

uncenter reviewed

View reviewed changes

scripts/import-styles/main.ts Outdated

isabelroses and others added 3 commits

December 13, 2023 22:24


          docs(import): improrve comments

9f2716b

Co-authored-by: uncenter <47499684+uncenter@users.noreply.github.com>


          fix: user better deno apis Co-authored-by: uncenter <47499684+uncente…

95efe1c

…r@users.noreply.github.com>


          refactor: use const for content

15743f4

uncenter reviewed

View reviewed changes

scripts/import-styles/main.ts Outdated

isabelroses and others added 3 commits

December 13, 2023 22:31


          ci(typos): ignore the complied json

f3cd5b5


          refactor: imporve useage

Co-authored-by: uncenter <47499684+uncenter@users.noreply.github.com>


          refactor: dont use @name outside of metadata block

465926d

isabelroses requested review from GlowingUmbreon, coldenate, pocco81 and skelebro1 as code owners

December 13, 2023 23:17

github-actions Bot added chess.com github labels

uncenter approved these changes

View reviewed changes

isabelroses commented Dec 14, 2023 •

edited

Loading

Member Author

~~This PR will need refactoring as of #400 being merged~~


          Merge branch 'main' into ci/gen-import

1646efc

uncenter mentioned this pull request

ci(lint): validate name metadata #402

Merged

sgoudham previously requested changes

View reviewed changes

README.md Outdated

nekowinston suggested changes

View reviewed changes

scripts/import-styles/main.ts Outdated

.github/workflows/generate-import.yml Outdated

styles/github/catppuccin.user.css

isabelroses added 3 commits

December 15, 2023 11:40


          refactor: combine lint and build workflows

16f8368


          fix: follow winstons suggestions

6c47288


          chore: restore github userstyle

3e768fd

github-actions Bot removed the github label


          fix: readd env

b7d6664

nekowinston reviewed

View reviewed changes

.github/workflows/lint-build.yml

nekowinston suggested changes

View reviewed changes

scripts/import-styles/main.ts Outdated

scripts/import-styles/main.ts Outdated

This comment was marked as resolved.

Sign in to view

isabelroses and others added 3 commits

December 15, 2023 13:03


          chore(gitignore): add dist dir

911bf98


          ci: only build on ctp repo on main branch

4da7aa8


          fix: follow suggestions

ca28755

Co-authored-by: nekowinston <hey@winston.sh>

nekowinston approved these changes

View reviewed changes

nekowinston left a comment

Contributor

LGTM.
The last thing we need to do is create that release that we're continuously uploading to.
import-styles for the name seems a bit vague? stylus-backup? latest? nightly? I don't know really.

nekowinston requested a review from sgoudham

December 15, 2023 13:16

nekowinston dismissed sgoudham’s stale review

December 15, 2023 13:16

resolved

isabelroses commented Dec 15, 2023 •

edited

Loading

Member Author

import-styles for the name seems a bit vague? stylus-backup? latest? nightly? I don't know really.

I quite like what @uncenter been referring to it as, "stylus export", beyond that i'm unsure either.

coldenate approved these changes

View reviewed changes

sgoudham commented Dec 15, 2023 •

edited

Loading

Contributor

Why can't we name it what it is, all-userstyles-export? all-userstyles-backup? all-userstyles?
Just throwing out suggestions in case it sparks a lightbulb idea for anyone else.

uncenter commented Dec 15, 2023

Member

I vote for all-userstyles-export!

isabelroses commented Dec 15, 2023

Member Author

I vote for all-userstyles-export!

This makes sense also has my vote.

nekowinston commented Dec 15, 2023

Contributor

i don't care


          chore: rename release

2efaa84

nekowinston reviewed

View reviewed changes

README.md Outdated


          refactor: point towards specific release

0c5d778

nekowinston commented Dec 15, 2023 •

edited

Loading

Contributor

I've marked it as a pre-release, tag is up: https://github.com/catppuccin/userstyles/releases/tag/all-userstyles-export

The tag doesn't matter, we won't have to update it. Should be good to merge.

isabelroses merged commit a789798 into main

isabelroses deleted the ci/gen-import branch

December 15, 2023 15:37

isabelroses commented Dec 15, 2023

Member Author

The CI is failing https://github.com/catppuccin/userstyles/actions/runs/7224061024/job/19684480303, due to a lack of GH_TOKEN.

nekowinston commented Dec 15, 2023

Contributor

And here I was worried that it was going to work in a single commit 🙃

Would you mind fixing it?

isabelroses commented Dec 15, 2023

Member Author

Would you mind fixing it?

I would have done it already but i had to run. Should be able to do it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

+2 more reviewers

Labels

None yet