Skip to content

fix(lichess): unthemed elements - #652

Closed
kingofcube wants to merge 20 commits into
catppuccin:mainfrom
kingofcube:main
Closed

fix(lichess): unthemed elements#652
kingofcube wants to merge 20 commits into
catppuccin:mainfrom
kingofcube:main

Conversation

@kingofcube

Copy link
Copy Markdown

馃敡 What does this fix? 馃敡

themed the color of the "Your turn" in the "X Game in play"
is it even allowed to make a pull request for the same thing?

馃棐 Checklist 馃棐

  • I have read and followed Catppuccin's contributing guidelines.
  • I have updated the version appropriately in the ==UserStyle== header of the catppuccin.user.css file.

@kingofcube
kingofcube requested a review from coopw1 as a code owner March 10, 2024 21:10
@github-actions github-actions Bot added the lichess Lichess label Mar 10, 2024
@kingofcube

This comment was marked as resolved.

@isabelroses isabelroses changed the title fix(lichess) themed the color of the "Your turn" in the "X Game in play" fix(lichess): themed the color of the "Your turn" in the "X Game in play" Mar 10, 2024
@isabelroses

Copy link
Copy Markdown
Member

Please see the linter errors.

@kingofcube

This comment was marked as off-topic.

Comment thread styles/lichess/catppuccin.user.css Outdated
background-image: url("data:image/svg+xml,@{svg}") !important;
}
.is2d .pawn {
.is2d .pawn when (@ChangePieces = 1) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of this stuff below can be nested. Something like:

.is2d when (@ChangePieces = 1) {
	.pawn { ... }
	...
}

@kingofcube

This comment was marked as outdated.

@var select lightFlavor "Light Flavor" ["latte:Latte*", "frappe:Frapp茅", "macchiato:Macchiato", "mocha:Mocha"]
@var select darkFlavor "Dark Flavor" ["latte:Latte", "frappe:Frapp茅", "macchiato:Macchiato", "mocha:Mocha*"]
@var select accentColor "Accent" ["rosewater:Rosewater", "flamingo:Flamingo", "pink:Pink", "mauve:Mauve", "red:Red", "maroon:Maroon", "peach:Peach", "yellow:Yellow", "green:Green", "teal:Teal", "blue:Blue", "sapphire:Sapphire*", "sky:Sky", "lavender:Lavender", "subtext0:Gray"]
@var checkbox ChangePieces "Change the chess pieces." 1

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@var checkbox ChangePieces "Change the chess pieces." 1
@var checkbox changePieces "Theme chess pieces." 1

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now an issue again since you undid it. And yes, you do have to change the name of the variable wherever you are using it!

kingofcube and others added 4 commits March 10, 2024 17:20
Co-authored-by: uncenter <47499684+uncenter@users.noreply.github.com>
Co-authored-by: uncenter <47499684+uncenter@users.noreply.github.com>
@kingofcube

This comment was marked as off-topic.

@isabelroses

Copy link
Copy Markdown
Member

what the fuck you mean "Expected complex :not() pseudo-class notation (selector-not-notation)"????

it means going from something like .fbt:hover:not(.disabled):not([disabled]) to .fbt:hover:not(.disabled, [disabled])

@kingofcube

This comment was marked as spam.

@kingofcube

This comment was marked as spam.

@uncenter

Copy link
Copy Markdown
Member

what the fuck you mean "Expected complex :not() pseudo-class notation (selector-not-notation)"????

Let's avoid swear words if possible...

@uncenter

Copy link
Copy Markdown
Member

what the fuck you mean "Expected complex :not() pseudo-class notation (selector-not-notation)"????

FYI it worked until you undid my suggestion... 8c3dde0 (#652).

Comment thread styles/lichess/catppuccin.user.css
}
.rclock.running .time {
background: #384722; /* putting it back to default so that the time on the clock is readable */
.rclock.running .time, :root:has(body[data-theme="system"]) .rclock.running .time {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this :root:has(body[data-theme="system"]) needed?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to remove it

@uncenter uncenter changed the title fix(lichess): themed the color of the "Your turn" in the "X Game in play" fix(lichess): unthemed elements Mar 14, 2024
@uncenter uncenter added the 2.status: changes-requested Changes requested by reviewers must be attended to by author before further review label Mar 19, 2024
@isabelroses

Copy link
Copy Markdown
Member

Hello @kingofcube can we get an update on this, or I will close it in a week as stale.

@isabelroses

Copy link
Copy Markdown
Member

Closing as stale, please reopen the PR when you are ready to complete the suggested changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: changes-requested Changes requested by reviewers must be attended to by author before further review lichess Lichess

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants