feat(wikipedia): add option for redirect highlight - #832
Merged
Conversation
Member
I actually quite like this and the implementation you went with works pretty well. Thank you. |
isabelroses
approved these changes
Apr 22, 2024
NK308
pushed a commit
to NK308/catppuccin-userstyles
that referenced
this pull request
May 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
馃敡 What does this fix? 馃敡
This puts the green redirect highlight behind an option, as it does not seem to be Wikipedia's default behavior and feels opinionated.
I've done this instead of outright requesting to remove it, as the contributing guide does not seem to outright prevent this since it's just a color change. However, it feels against the spirit of the opinionated section to me, and I also just don't like the green 馃檭
On (previously the only behavior):

Off (added in this PR):

馃棐 Checklist 馃棐
==UserStyle==header of thecatppuccin.user.cssfile.