Skip to content

feat(wikipedia): add option for redirect highlight - #832

Merged
isabelroses merged 4 commits into
catppuccin:mainfrom
hf02:patch-2
Apr 22, 2024
Merged

feat(wikipedia): add option for redirect highlight#832
isabelroses merged 4 commits into
catppuccin:mainfrom
hf02:patch-2

Conversation

@hf02

@hf02 hf02 commented Apr 22, 2024

Copy link
Copy Markdown
Contributor

馃敡 What does this fix? 馃敡

This puts the green redirect highlight behind an option, as it does not seem to be Wikipedia's default behavior and feels opinionated.

I've done this instead of outright requesting to remove it, as the contributing guide does not seem to outright prevent this since it's just a color change. However, it feels against the spirit of the opinionated section to me, and I also just don't like the green 馃檭

On (previously the only behavior):
image

Off (added in this PR):
image

馃棐 Checklist 馃棐

  • I have read and followed Catppuccin's contributing guidelines.
  • I have updated the version appropriately in the ==UserStyle== header of the catppuccin.user.css file.

@hf02
hf02 requested a review from mustafa-archived as a code owner April 22, 2024 17:15
@github-actions github-actions Bot added the wikipedia Wikipedia label Apr 22, 2024
@isabelroses

Copy link
Copy Markdown
Member

This puts the green redirect highlight behind an option, as it does not seem to be Wikipedia's default behavior and feels opinionated.

I actually quite like this and the implementation you went with works pretty well. Thank you.

@isabelroses
isabelroses merged commit b8a6697 into catppuccin:main Apr 22, 2024
NK308 pushed a commit to NK308/catppuccin-userstyles that referenced this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wikipedia Wikipedia

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants