Skip to content

feat(stack-overflow): init - #918

Merged
uncenter merged 12 commits into
mainfrom
feat/stack-overflow
May 27, 2024
Merged

feat(stack-overflow): init#918
uncenter merged 12 commits into
mainfrom
feat/stack-overflow

Conversation

@uncenter

@uncenter uncenter commented May 25, 2024

Copy link
Copy Markdown
Member

馃帀 Theme for Stack Overflow 馃帀

Followup of #549.

馃挰 Additional Comments 馃挰

馃棐 Checklist 馃棐

  • I have read and followed Catppuccin's submission guidelines.
  • I have made a new directory underneath /styles/<name-of-website> containing the contents of the /template directory.
    • I have ensured that the new directory is in lower-kebab-case.
    • I have followed the template and kept the preprocessor as LESS.
  • I have made sure to update the
    userstyles.yml
    file with information about the new userstyle.
  • I have included the following files:
    • catppuccin.user.css - all the CSS for the userstyle, based on the
      template.
    • preview.webp - composite image of all four individual flavor screenshots stitched together,
      generated via Catwalk.

@uncenter
uncenter marked this pull request as ready for review May 25, 2024 23:33
@isabelroses
isabelroses self-requested a review May 25, 2024 23:36
@isabelroses

Copy link
Copy Markdown
Member

Active Hover buttons seem a bit off, since the active is accent.
image
The scroll bar here is a bit hard to see, reproducible here -> https://stackoverflow.com/questions/78535928/net-maui-xaml-data-binding-failures-on-int32-doubles
image
hr looks off, https://stackoverflow.com/jobs/companies/deutsche-b%C3%B6rse-group
image
Expansion arrow too
image

@uncenter

uncenter commented May 26, 2024

Copy link
Copy Markdown
Member Author

Active Hover buttons seem a bit off, since the active is accent. image

Fixed.

The scroll bar here is a bit hard to see, reproducible here -> stackoverflow.com/questions/78535928/net-maui-xaml-data-binding-failures-on-int32-doubles image

Unable to repro.

hr looks off, stackoverflow.com/jobs/companies/deutsche-b%C3%B6rse-group image

Is subtext1, not really fixable since it uses colors from other areas. I think it looks fine enough for now.

Expansion arrow too image

Where can I find this?

@isabelroses

Copy link
Copy Markdown
Member

Where can I find this?

I cannot find this any more rofl. But the rest seems fixed.

@uncenter

Copy link
Copy Markdown
Member Author

Leaving open for a few days to see if any other issues pop up.

@r58Playz

r58Playz commented May 26, 2024

Copy link
Copy Markdown
Member

The scroll bar here is a bit hard to see, reproducible here -> stackoverflow.com/questions/78535928/net-maui-xaml-data-binding-failures-on-int32-doubles image

Unable to repro.

I am able to repro this on the codeblock. Note that I am signed out.

image
Collectives look weird.

image
Add a comment contrast is low.

image
Border of "Thanks for contributing" looks unthemed.

image
Homepage contrast is very low. There's more if you scroll down.

image
Collective homepage pill list is unthemed. Scrolling down...

image
Accepted answer is unthemed.

@uncenter
uncenter requested a review from r58Playz May 27, 2024 03:42
@uncenter

Copy link
Copy Markdown
Member Author

Fixed most of that. Won't be prioritizing theming the homepage since it is rarely seen once logged in and using the website.

@uncenter
uncenter merged commit 9fb0e80 into main May 27, 2024
@uncenter
uncenter deleted the feat/stack-overflow branch May 27, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants