fix(proton): light color scheme for message iframe - #919
Merged
Conversation
uncenter
approved these changes
May 25, 2024
Contributor
Author
|
Similar approach might fix #902. Will take a look tomorrow. |
soya-daizu
reviewed
May 26, 2024
Contributor
There was a problem hiding this comment.
The problem is that when the email is just a plantext, it already shows light text with dark background and works fine. I personally don't want to force everything to be in light color scheme if it blends in to the dark color scheme.
I will look into the problem and see if I could fix this without forcing light color.
soya-daizu
requested changes
May 26, 2024
Lichthagel
force-pushed
the
fix/proton/message-text
branch
from
May 26, 2024 09:11
a28644d to
b9b8bc2
Compare
soya-daizu
approved these changes
May 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
馃敡 What does this fix? 馃敡
Fixes #828 by setting
color-scheme: light;for the iframe containing the message.馃棐 Checklist 馃棐
==UserStyle==header of thecatppuccin.user.cssfile.