Skip to content

Handle lxml raising ValueError on node.itertext() #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codelucas merged 2 commits into from
Jan 14, 2016
Merged

Handle lxml raising ValueError on node.itertext() #144

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c96c9f1
Handle lxml raising ValueError on node.itertext()
yprez May 13, 2015
b7ee7ed
Add logging on failure to parse an lxml node
yprez Jan 11, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion newspaper/outputformatters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,14 @@
__copyright__ = 'Copyright 2014, Lucas Ou-Yang'

from HTMLParser import HTMLParser
import logging

from .text import innerTrim


log = logging.getLogger(__name__)


class OutputFormatter(object):

def __init__(self, config):
Expand Down Expand Up @@ -60,7 +64,12 @@ def get_formatted(self, top_node):
def convert_to_text(self):
txts = []
for node in list(self.get_top_node()):
txt = self.parser.getText(node)
try:
txt = self.parser.getText(node)
except ValueError: # lxml error

@codelucas codelucas Jan 10, 2016

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should at least print out warnings + fail loudly if this happens. Maybe notify the url that failed so the developer can triage further? The ideal is to debug urls that don't work so the library can slowly extract more successfully.

log.warning('Error parsing lxml node', exc_info=True)
txt = None

if txt:
txt = HTMLParser().unescape(txt)
txt_lis = innerTrim(txt).split(r'\n')
Expand Down