Skip to content

First attempts at py3k - #38

Closed
metakermit wants to merge 5 commits into
codelucas:masterfrom
metakermit:py3k
Closed

First attempts at py3k#38
metakermit wants to merge 5 commits into
codelucas:masterfrom
metakermit:py3k

Conversation

@metakermit

Copy link
Copy Markdown

Related to #36. This shouldn't be merged yet (incomplete). I want to start the conversation around the porting effort, though.

@metakermit

Copy link
Copy Markdown
Author

2to3 fixed what it could. I replaced some modules with their py3-compatible equivalents (mostly development branches). I had to get rid of the vendored code, as a lot of it was py3-incompatible and there do exist compatible upstream versions, so using them as packages was more elegant. I got to the point where I can import the newspaper module and most of the tasks I can reach with nose pass. I currently hit a wall due to the @print_test decorator, which doesn't work with nose (which I use for testing and debugging). I placed some decode calls clumsily, I'd say. It would be good if a central strategy for turning bytes to str (unicode) was thought out, so that it happens as early as possible.

There is still plenty of work, I'd say, but it's a start. For now, a goal could be to be able to publish this as another package on PyPI (newspaper3) and then maybe slowly merge the two code-bases by adding from future import ... and six stuff.

@codelucas

Copy link
Copy Markdown
Owner

Excellent job so far! I'm glad you are doing this.

@codelucas

Copy link
Copy Markdown
Owner

Closing this due to #86

@codelucas codelucas closed this Nov 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants