Skip to content

removed quotes of 'filename' in utils\__init__.py - #53

Merged
codelucas merged 1 commit into
codelucas:masterfrom
linbianxiaocao:jiepatch
May 31, 2014
Merged

removed quotes of 'filename' in utils\__init__.py#53
codelucas merged 1 commit into
codelucas:masterfrom
linbianxiaocao:jiepatch

Conversation

@linbianxiaocao

Copy link
Copy Markdown
Contributor

Hi codelucas, this should be a small errata. I think the single quotes should be removed. Could you verify please?

@codelucas

Copy link
Copy Markdown
Owner

You are correct, i'm merging.

If you don't mind me asking, what implications did this bug end up having for you? Or
did you just notice it when glancing at the code.

codelucas added a commit that referenced this pull request May 31, 2014
removed quotes of 'filename' in utils\__init__.py
@codelucas
codelucas merged commit 1fcb993 into codelucas:master May 31, 2014
@linbianxiaocao

Copy link
Copy Markdown
Contributor Author

I was reading your code and found it as an errata. It seems the code always
produce the right path even passing single-quoted 'filename'. It doesn't
cause any wrong behavior though. Thought it'd be best to correct anyway.
Maybe next time I can send a pull request with more substantial changes.

Thanks for merging and your good project.

On Sat, May 31, 2014 at 2:09 PM, Lucas Ou notifications@github.com wrote:

Merged #53 #53.


Reply to this email directly or view it on GitHub
#53 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants