Allow configuration of base directory - #532
Closed
prevostc wants to merge 4 commits into
Closed
Conversation
Owner
|
Great idea, thanks for implementing this @prevostc. Will take a look / test and likely merge in a few days! 👍 💯 |
Contributor
|
+1 |
Author
|
This PR is now 1.5 year old, which is a billion serverless years. I'm closing it :) |
|
Why did this not get merged? This is really needed in my opinion. |
|
Hello, Is this change in the 0.2.8 release? I did a pip install of the latest release as of March 2, 2020, and I don't see any NEWSPAPER_BASE_DIRECTORY. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was able to make newspaper work on aws lambda with this PR update and the following code
This PR is also handy for AWS Beanstalk as the
/home/wsgifolder do not exists and you also need to configure the directory