Test suite improvements

[karls]

Don't do HTTP requests in tests.

[codelucas]

Hallelujah! Let me read this over and test it locally before merging.
👍 for explicit versions in requirements.txt.

[jeffnappi]

vcrpy may also be good for this: https://github.com/kevin1024/vcrpy

[karls]

@jeffnappi that's a good shout, cheers!

I think it's up to @codelucas, ultimately. Personally, I think it might be a good idea to introduce something like vcrpy when we have a larger test suite. I'm not opposed to doing it straight away, though, if people think it's more benficial.

[codelucas]

@karls Upon looking at this here are a few bugs that I found:
The responses library is being imported but it isn't included in the requirements.txt.
The mock library is included in requirements.txt but never used.

Everything else works perfectly!
But please update as needed, thanks. I'll merge this by the end of today after you update.

[karls]

@codelucas responses was actually in requirements.txt, but it's currently installed from my fork of the library, because I have an upstream patch that adds regex URL matching, but it's not merged yet. As soon as I get this merged, we can switch to the original one.

mock was just a hangover from some experimentation that I did, whoops.

Have another look over it and let me know if anything else needs changing.

[codelucas]

Got it, i'm going to merge this and expect the third diff to come shortly!